-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pivot to pyproject.toml for setuptools packaging #994
base: master
Are you sure you want to change the base?
Pivot to pyproject.toml for setuptools packaging #994
Conversation
See #893 |
… script cd being built in most unix OS it cannot be called using cd.sh() as there is no existing binary on the machine.
313d50d
to
bc5971e
Compare
bc5971e
to
820571a
Compare
A discussion is needed regarding the scripts in the INGInious package using docker compose. They are not needed and where ignored conditionnaly with a boolean in setup.py. It is however not possible with the pyproject.toml file. Using two different pyproject.toml files does not seem to be achievable :
So either we accept the presence of unused scripts in the docker compose package (not that many) or we comment the pyproject.toml scripts before building it. |
This PR will be reconsidered after the definition of a new backend architecture and services separation. |
Using pyproject.toml is the new standardized way to declare packaging metadata. As it is the new standard there will likely be less problems related to the packaging of INGInious.
Rem : setup.py is still usable and the configuration in pyproject.toml overwrites that of setup.py. For the moment the scripts are left in setup.py because of the condition on INGINIOUS_COMPOSE environment variable that can not be done in toml files.
TO DO :
-> deleted + not using nose testing anymore
sh.CommandNotFound: cd
)-> two pyproject.toml files (with and without scripts depending on the use of docker compose or not)