Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - removed indentation in tutorial #1027

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anaHue
Copy link
Contributor

@anaHue anaHue commented Dec 8, 2024

This is a PR to solve an issue related to the doc.

Looking at the tutorial of how to write an hello world exercise, it stated an example of the code to put in a template file to run the student code.

The problem is that the student code is inside the function and the funtion was called at the end of the function instead of being called after the function definition. This would result in not being able to run the student code but even by running the function it will be an infinite loop.

To solve this, I had to remove one indentation level as Python works with identation at the right level to call a function. By testing, the code was indeed showing nothing before the change and displayed "hello world" after changes.

@AlexandreDoneux
Copy link
Contributor

You gave no explanation on what the problem was and how you fixed it. Please provide those in your PR description.

Also provide proof there was a problem and that your changes are valid and do not cause more problems.

@anaHue
Copy link
Contributor Author

anaHue commented Dec 20, 2024

Indeed I forgot to give context as I thought it was clear of the changes I did. I added what you asked and hope it is greatly structured. Thanks for the feedback, I tend to forgot to bring context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants