Issue with file extension in file subproblem #1017
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -236,7 +236,7 @@ def parse_problem(self, problem_content): | |||
| if problem_content["allowed_exts"] == "": | |||
| del problem_content["allowed_exts"] | |||
| else: | |||
| problem_content["allowed_exts"] = problem_content["allowed_exts"].split(',') | |||
| problem_content["allowed_exts"] = [extension.strip() for extension in problem_content["allowed_exts"].split(',')] | |||
There was a problem hiding this comment.
Suggested change
| problem_content["allowed_exts"] = [extension.strip() for extension in problem_content["allowed_exts"].split(',')] | |
| problem_content["allowed_exts"] = problem_content["allowed_exts"].replace(" ", "").split(',') |
There was a problem hiding this comment.
Other than that, looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code isn’t removing extra spaces when splitting the file extensions. So if you input something like ".pdf, .png", it ends up with " .png" (with a space) instead of just ".png". Because of this, files with the ".png" extension won’t be recognized properly.