Remove old url redirection and add form reset #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -247,10 +247,10 @@ | |||
|
|
|||
| <!-- Validate --> | |||
| <div class="btn-group pull-right mb-2"> | |||
| <button type="button" class="btn btn-danger btn-block m-1 p-2 pl-4 pr-4" onclick="window.location.href='{{get_homepath()}}/admin/{{course.get_id()}}/new_submissions'"> | |||
| <button id="reset_button" type="button" class="btn btn-danger btn-block m-1 p-2 pl-4 pr-4" onclick="document.getElementById('select_form').reset();document.getElementById('filter_button').click();"> | |||
There was a problem hiding this comment.
This quite a stretch and not optimal. The actual solutions simply redirects to a page (with a url we need to change).
Your solution resets the form, submits the default filter to the server, the server handles it and responds to the frontend which redirects you to the page.
Just change the URL of the actual code : onclick="window.location.href='{{get_homepath()}}/admin/{{course.get_id()}}/submissions'"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves 404 error when clicking on reset button
#1010
#980