Compatibility fix to run webapp with python3.10 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonygego
reviewed
Jul 25, 2022
| @@ -224,11 +224,12 @@ | |||
| XHTML support was contributed by Michael Haubenwallner. | |||
| ''' | |||
| from __future__ import with_statement | |||
| from cgitb import html | |||
There was a problem hiding this comment.
It looks like this package will be deprecated in Python 3.11. Can you see if this can't be replaced by any Flask API ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have updated some lines of the code in libs/html.py and common/utils to make ictv work with python3.10. These changes are also compatible with version 3.6 for production.