Empty suptops #352
Merged
Empty suptops #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to an error. Here we throw them out early.
… atoms that can be removed. I am not sure how this is arising. We've scanned huge numbers of molecules and this is a first. However, due to lack of time, this is ignored for now.
bieniekmateusz
deleted the
fix-rare-case-removed-matches-leaving-none-suptops
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another rare case where a few suptops make it to the end just to be emptied due to poor charges and other heuristics.
Here we simply ignore the bad pairings and return None to indicate that.