Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve calculation of dropped variables set #52

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

douglatornell
Copy link
Member

Use the 1st and last dataset paths to calculate a more complete set of all variables in the dataset. That avoids the inclusion in the extracted dataset of variables that were added to the dataset during the extraction time span.

Fixes issue #51

Use the 1st and last dataset paths to calculate a more complete set of all
variables in the dataset. That avoids the inclusion in the extracted dataset of
variables that were added to the dataset during the extraction time span.

Fixes issue #51
@douglatornell douglatornell added the bug Something isn't working label Sep 14, 2022
@douglatornell douglatornell added this to the v22.1 milestone Sep 14, 2022
@douglatornell douglatornell self-assigned this Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #52 (8b4220b) into main (6688b24) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   96.65%   96.59%   -0.07%     
==========================================
  Files          15       15              
  Lines        1585     1586       +1     
  Branches      139      140       +1     
==========================================
  Hits         1532     1532              
- Misses         50       51       +1     
  Partials        3        3              
Flag Coverage Δ
unittests 96.59% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
reshapr/core/extract.py 84.84% <0.00%> (-0.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@douglatornell douglatornell merged commit f2ca65b into main Sep 14, 2022
@douglatornell douglatornell deleted the issue51 branch September 14, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrequested variable in extractions that span date of variable added to dataset
1 participant