Add yyyy() and nemo_yyyymm() date formatters. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling nc_file_pattern from config as a str instead of a Path allows replacement of formatted date placeholders in both path and filename sections in a single .format() call. That make the code suitable to change from a loop to a list comprehension.
Caught by PyCharm code analyzer. Probably due to change in type annotations in xarray=2022.06.0.
douglatornell
added
documentation
|
Unfortunately, this in only part of what is required to handle the coarsened SalishSeaCast files. They are the product of |
This automatically installs the package as part of environment creation. Thanks to Michael for the tip that this is possible.
Use local timezone to resolve arrow pkg parsing exception, and add timezone offset to formatted date/time to make it location agnostic. re: issue #42
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 96.53% 96.55% +0.02%
==========================================
Files 13 15 +2
Lines 1528 1539 +11
Branches 137 138 +1
==========================================
+ Hits 1475 1486 +11
Misses 50 50
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Add auto-generated API docs for date formatter functions so that they are discoverable for model profile creators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports Greig's use of Reshapr for his coarsened SalishSeaCast hindcast work.
Also includes a refactoring of:
reshapr.utils.date_formattersmodule