-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abbyy2hocr transformation by @OCR-D #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a reason why it should not be included here but after actually testing it, I am not very impressed with the results as a) it does not produce valid output from our ABBYY files and b) it requires a few mandatory parameters that are not always available. Maybe including it in ocr-fileformat will increase the visibility of the transformation so that those shortcomings can be remedied.
Can you open issues at https://github.com/OCR-D/format-converters/issues lest we forget @jmechnich? Thank you |
@kba Yes, thank you for the suggestion. That is what we discussed last Friday and I said that I will do that. We also discussed that at least the required parameters should be make optional for the integration here, because otherwise it might not be possible to use that in the GUI. |
Here is a PR for making the parameters optional: OCR-D/format-converters#8 |
The upstream PR is merged now. @jmechnich Can you test the new version where the parameters are not mandatory anymore? Is this now giving results in the GUI? |
Upstream is already broken by another commit. :) |
Here is PR for fixing the newly introduced regressions OCR-D/format-converters#11 BTW I would love to see also some tests integrated with CI in the upstream repo. |
Okay, upstream is merged now again. @jmechnich Can you give it a try again? 🙏 |
I did not yet test it, but it looks straightforward.