Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcv__page: use -source-json instead of -source-xml #156

Merged
merged 1 commit into from
Nov 25, 2022
Merged

gcv__page: use -source-json instead of -source-xml #156

merged 1 commit into from
Nov 25, 2022

Conversation

bertsky
Copy link
Contributor

@bertsky bertsky commented Nov 17, 2022

No description provided.

@bertsky bertsky mentioned this pull request Nov 17, 2022
Open
stweil
stweil approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stweil
Copy link
Member

stweil commented Nov 17, 2022

I'd like to run a test before merging and ideally there should also be a unit test. Can we get a (small) GCV file for such tests?

@stweil stweil merged commit 85c6325 into UB-Mannheim:master Nov 25, 2022
@stweil
Copy link
Member

stweil commented Nov 25, 2022

A test is still missing. I decided to pull the commit nevertheless because I expect that it improves the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stweil stweil stweil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertsky @stweil