Skip to content

Remove explicit Microsoft.SourceLink.GitHub package references#943

Merged
Tyrrrz merged 2 commits intomasterfrom
copilot/remove-source-link-package
Mar 2, 2026
Merged

Remove explicit Microsoft.SourceLink.GitHub package references#943
Tyrrrz merged 2 commits intomasterfrom
copilot/remove-source-link-package

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 2, 2026

Since .NET 8 SDK, Source Link support for GitHub-hosted repos is built into the SDK — the Microsoft.SourceLink.GitHub NuGet package is no longer needed.

Changes

  • Removed <PackageReference Include="Microsoft.SourceLink.GitHub" ... /> from YoutubeExplode/YoutubeExplode.csproj and YoutubeExplode.Converter/YoutubeExplode.Converter.csproj
  • Removed the corresponding <PackageVersion> entry from Directory.Packages.props
Original prompt

Background

Since .NET 8 SDK, Source Link support is built directly into the SDK for GitHub-hosted repositories. It is no longer necessary to explicitly reference the Microsoft.SourceLink.GitHub NuGet package.

Task

Remove all explicit references to Microsoft.SourceLink.GitHub from the project:

  1. In YoutubeExplode/YoutubeExplode.csproj, remove the following line:

    <PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="all" />
  2. In Directory.Packages.props, remove the following line:

    <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.103" />

Do not make any other changes. The built-in SDK Source Link support will take over automatically.

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ET 8+ SDK)

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove explicit references to Microsoft.SourceLink.GitHub Remove explicit Microsoft.SourceLink.GitHub package references Mar 2, 2026
@Tyrrrz Tyrrrz marked this pull request as ready for review March 2, 2026 11:29
Copilot AI review requested due to automatic review settings March 2, 2026 11:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes redundant explicit Source Link package references now that the .NET SDK provides GitHub Source Link support without needing Microsoft.SourceLink.GitHub.

Changes:

  • Removed Microsoft.SourceLink.GitHub PackageReference from YoutubeExplode and YoutubeExplode.Converter projects.
  • Removed the centrally-managed PackageVersion for Microsoft.SourceLink.GitHub from Directory.Packages.props.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
YoutubeExplode/YoutubeExplode.csproj Drops the explicit Microsoft.SourceLink.GitHub package reference.
YoutubeExplode.Converter/YoutubeExplode.Converter.csproj Drops the explicit Microsoft.SourceLink.GitHub package reference.
Directory.Packages.props Removes the central version entry for Microsoft.SourceLink.GitHub.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 2916232 into master Mar 2, 2026
11 checks passed
@Tyrrrz Tyrrrz deleted the copilot/remove-source-link-package branch March 2, 2026 11:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (284083a) to head (4c3d52b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff      @@
##   master   #943   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants