Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Oct 3, 2025

No description provided.

Since our model doesn't support those kind of videos right now, we simply extract the first author in the list.
Copilot AI review requested due to automatic review settings October 3, 2025 23:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a workaround for handling YouTube videos that have multiple authors by extracting the first author when the primary author extraction method fails. The change ensures that video data can still be retrieved even when YouTube's API structure differs for multi-author videos.

Key changes:

  • Added fallback logic for author ID extraction when videos have multiple authors
  • Included explanatory comments about the limitation of the current data model

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +59 to +76
?? AuthorDetails
?.GetPropertyOrNull("navigationEndpoint")
?.GetPropertyOrNull("showDialogCommand")
?.GetPropertyOrNull("panelLoadingStrategy")
?.GetPropertyOrNull("inlineContent")
?.GetPropertyOrNull("dialogViewModel")
?.GetPropertyOrNull("customContent")
?.GetPropertyOrNull("listViewModel")
?.GetPropertyOrNull("listItems")
?.EnumerateArrayOrNull()
?.FirstOrNull()
?.GetPropertyOrNull("listItemViewModel")
?.GetPropertyOrNull("rendererContext")
?.GetPropertyOrNull("commandContext")
?.GetPropertyOrNull("onTap")
?.GetPropertyOrNull("innertubeCommand")
?.GetPropertyOrNull("browseEndpoint")
?.GetPropertyOrNull("browseId")
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deeply nested property chain is difficult to maintain and understand. Consider extracting this logic into a separate helper method with meaningful intermediate variable names to improve readability and debuggability.

Copilot uses AI. Check for mistakes.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skill issue tbh

@Tyrrrz Tyrrrz merged commit 51d3f99 into master Oct 3, 2025
7 checks passed
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (f78dbcf) to head (01197ef).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff      @@
##   master   #911   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants