Skip to content

ToSemanticString should always return 3-component version string #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyrrrz merged 2 commits into from
Jul 24, 2026
Merged

ToSemanticString should always return 3-component version string #94

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ef1c51
fix: ToSemanticString pads to 3 components when Build is unset
Copilot Jul 24, 2026
582d8e5
Potential fix for pull request finding
Tyrrrz Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PowerKit.Tests/Extensions/VersionExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class VersionExtensionsTests
[Fact]
public void ToSemanticString_Test()
{
new Version(1, 2).ToSemanticString().Should().Be("1.2");
new Version(1, 2).ToSemanticString().Should().Be("1.2.0");
new Version(1, 2, 3).ToSemanticString().Should().Be("1.2.3");
new Version(1, 2, 3, 4).ToSemanticString().Should().Be("1.2.3.4");
new Version(1, 2, 3, 0).ToSemanticString().Should().Be("1.2.3");
Expand Down
3 changes: 2 additions & 1 deletion PowerKit/Extensions/VersionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@ public static class VersionExtensions
{
/// <summary>
/// Formats the version as a semantic version string, omitting the revision component if it is not set or is zero.
/// Missing build or patch components are replaced with zero to ensure at least three components are present.
/// </summary>
Comment thread
Copilot marked this conversation as resolved.
public string ToSemanticString() =>
version.Build < 0 ? version.ToString(2)
version.Build < 0 ? version.ToString(2) + ".0"
: version.Revision <= 0 ? version.ToString(3)
: version.ToString();
}
Expand Down