Skip to content

Add endianness-aware BinaryReader/BinaryWriter extensions; bump PolyShim to 2.12.1 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyrrrz merged 8 commits into from
Jul 20, 2026
Merged

Add endianness-aware BinaryReader/BinaryWriter extensions; bump PolyShim to 2.12.1 #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
29924ce
Update PolyShim to 2.12.1
Copilot Jul 20, 2026
26c2a6c
Add endianness-aware BinaryReader/BinaryWriter extensions and tests
Copilot Jul 20, 2026
8bc2734
Fix formatting in Directory.Packages.props
Copilot Jul 20, 2026
d7d30da
Validate ReadBytes length and throw EndOfStreamException in Read*Endi…
Copilot Jul 20, 2026
05883c6
Bump PolyShim to 2.12.2 and drop #if guards on float/double overloads
Copilot Jul 20, 2026
6604665
Update BinaryReaderExtensions.cs
Tyrrrz Jul 20, 2026
f0efa9d
Rename BinaryWriter extensions to WriteBigEndian/WriteLittleEndian ov…
Copilot Jul 20, 2026
a934c52
Order BinaryWriter extension methods and tests by name
Copilot Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Directory.Packages.props
View file
Open in desktop
Comment thread
Tyrrrz marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
<PackageVersion Include="Gress" Version="2.2.0" />
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="10.0.8" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.7.0" />
<PackageVersion Include="PolyShim" Version="2.11.0" />
<PackageVersion Include="PolyShim" Version="2.12.2" />
Comment thread
Tyrrrz marked this conversation as resolved.
<PackageVersion Include="Snek" Version="1.0.0" />
<PackageVersion Include="System.Memory" Version="4.6.3" />
<PackageVersion Include="xunit" Version="2.9.3" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" />
<PackageVersion Include="Xunit.SkippableFact" Version="1.5.61" />
</ItemGroup>
</Project>
</Project>
240 changes: 240 additions & 0 deletions PowerKit.Tests/Extensions/BinaryReaderExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,244 @@ public void SkipZeroes_AllZeroes_Test()
// Assert
stream.Position.Should().Be(3);
}

[Fact]
public void ReadInt16BigEndian_Test()
{
// Arrange
var data = new byte[] { 0x01, 0x02 };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadInt16BigEndian();

// Assert
result.Should().Be(0x0102);
}

[Fact]
public void ReadInt16LittleEndian_Test()
{
// Arrange
var data = new byte[] { 0x02, 0x01 };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadInt16LittleEndian();

// Assert
result.Should().Be(0x0102);
}

[Fact]
public void ReadUInt16BigEndian_Test()
{
// Arrange
var data = new byte[] { 0xFF, 0xFE };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadUInt16BigEndian();

// Assert
result.Should().Be((ushort)0xFFFE);
}

[Fact]
public void ReadUInt16LittleEndian_Test()
{
// Arrange
var data = new byte[] { 0xFE, 0xFF };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadUInt16LittleEndian();

// Assert
result.Should().Be((ushort)0xFFFE);
}

[Fact]
public void ReadInt32BigEndian_Test()
{
// Arrange
var data = new byte[] { 0x01, 0x02, 0x03, 0x04 };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadInt32BigEndian();

// Assert
result.Should().Be(0x01020304);
}

[Fact]
public void ReadInt32LittleEndian_Test()
{
// Arrange
var data = new byte[] { 0x04, 0x03, 0x02, 0x01 };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadInt32LittleEndian();

// Assert
result.Should().Be(0x01020304);
}

[Fact]
public void ReadUInt32BigEndian_Test()
{
// Arrange
var data = new byte[] { 0xFF, 0xFE, 0xFD, 0xFC };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadUInt32BigEndian();

// Assert
result.Should().Be(0xFFFEFDFCu);
}

[Fact]
public void ReadUInt32LittleEndian_Test()
{
// Arrange
var data = new byte[] { 0xFC, 0xFD, 0xFE, 0xFF };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadUInt32LittleEndian();

// Assert
result.Should().Be(0xFFFEFDFCu);
}

[Fact]
public void ReadInt64BigEndian_Test()
{
// Arrange
var data = new byte[] { 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08 };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadInt64BigEndian();

// Assert
result.Should().Be(0x0102030405060708L);
}

[Fact]
public void ReadInt64LittleEndian_Test()
{
// Arrange
var data = new byte[] { 0x08, 0x07, 0x06, 0x05, 0x04, 0x03, 0x02, 0x01 };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadInt64LittleEndian();

// Assert
result.Should().Be(0x0102030405060708L);
}

[Fact]
public void ReadUInt64BigEndian_Test()
{
// Arrange
var data = new byte[] { 0xFF, 0xFE, 0xFD, 0xFC, 0xFB, 0xFA, 0xF9, 0xF8 };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadUInt64BigEndian();

// Assert
result.Should().Be(0xFFFEFDFCFBFAF9F8uL);
}

[Fact]
public void ReadUInt64LittleEndian_Test()
{
// Arrange
var data = new byte[] { 0xF8, 0xF9, 0xFA, 0xFB, 0xFC, 0xFD, 0xFE, 0xFF };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadUInt64LittleEndian();

// Assert
result.Should().Be(0xFFFEFDFCFBFAF9F8uL);
}

[Fact]
public void ReadSingleBigEndian_Test()
{
// Arrange — IEEE 754 big-endian bytes for 1.0f: 0x3F800000
var data = new byte[] { 0x3F, 0x80, 0x00, 0x00 };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadSingleBigEndian();

// Assert
result.Should().Be(1.0f);
}

[Fact]
public void ReadSingleLittleEndian_Test()
{
// Arrange — IEEE 754 little-endian bytes for 1.0f: 0x3F800000 reversed
var data = new byte[] { 0x00, 0x00, 0x80, 0x3F };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadSingleLittleEndian();

// Assert
result.Should().Be(1.0f);
}

[Fact]
public void ReadDoubleBigEndian_Test()
{
// Arrange — IEEE 754 big-endian bytes for 1.0d: 0x3FF0000000000000
var data = new byte[] { 0x3F, 0xF0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadDoubleBigEndian();

// Assert
result.Should().Be(1.0d);
}

[Fact]
public void ReadDoubleLittleEndian_Test()
{
// Arrange — IEEE 754 little-endian bytes for 1.0d: 0x3FF0000000000000 reversed
var data = new byte[] { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF0, 0x3F };
using var stream = new MemoryStream(data);
using var reader = new BinaryReader(stream);

// Act
var result = reader.ReadDoubleLittleEndian();

// Assert
result.Should().Be(1.0d);
}
}
Loading