-
Notifications
You must be signed in to change notification settings - Fork 1
Extract StreamPortal utility from Ressy into PowerKit #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| using System.IO; | ||
| using FluentAssertions; | ||
| using PowerKit.Extensions; | ||
| using Xunit; | ||
|
|
||
| namespace PowerKit.Tests; | ||
|
|
||
| public class StreamPortalTests | ||
| { | ||
| [Fact] | ||
| public void CreatePortal_AtCurrentPosition_Test() | ||
| { | ||
| // Arrange | ||
| var data = new byte[] { 1, 2, 3, 4, 5 }; | ||
| using var stream = new MemoryStream(data); | ||
| stream.Seek(2, SeekOrigin.Begin); | ||
|
|
||
| // Act | ||
| var portal = stream.CreatePortal(); | ||
|
|
||
| // Assert | ||
| portal.Position.Should().Be(2); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void CreatePortal_AtSpecifiedPosition_Test() | ||
| { | ||
| // Arrange | ||
| var data = new byte[] { 1, 2, 3, 4, 5 }; | ||
| using var stream = new MemoryStream(data); | ||
|
|
||
| // Act | ||
| var portal = stream.CreatePortal(3); | ||
|
|
||
| // Assert | ||
| portal.Position.Should().Be(3); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Jump_SeeksToPortalPositionAndRestoresOnDispose_Test() | ||
| { | ||
| // Arrange | ||
| var data = new byte[] { 1, 2, 3, 4, 5 }; | ||
| using var stream = new MemoryStream(data); | ||
| stream.Seek(1, SeekOrigin.Begin); | ||
| var portal = stream.CreatePortal(4); | ||
|
|
||
| // Act | ||
| var jump = portal.Jump(); | ||
|
|
||
| // Assert - seeks to portal position | ||
| stream.Position.Should().Be(4); | ||
|
|
||
| jump.Dispose(); | ||
|
|
||
| // Assert - restores original position on dispose | ||
| stream.Position.Should().Be(1); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| using System; | ||
| using System.IO; | ||
|
|
||
| namespace PowerKit; | ||
|
|
||
| /// <summary> | ||
| /// Represents a saved position in a stream that can be jumped to and returned from. | ||
| /// </summary> | ||
| public class StreamPortal(Stream stream, long position) | ||
| { | ||
| /// <summary> | ||
| /// Gets the position this portal points to. | ||
| /// </summary> | ||
| public long Position { get; } = | ||
| stream.CanSeek | ||
| ? position >= 0 | ||
| ? position | ||
| : throw new ArgumentOutOfRangeException( | ||
| nameof(position), | ||
| "Position must be non-negative." | ||
| ) | ||
| : throw new ArgumentException("Stream must support seeking.", nameof(stream)); | ||
|
|
||
| /// <summary> | ||
| /// Seeks the stream to the portal's position and returns a disposable that, | ||
| /// when disposed, seeks back to the original position. | ||
| /// </summary> | ||
| public IDisposable Jump() | ||
| { | ||
| var oldPosition = stream.Position; | ||
| stream.Seek(Position, SeekOrigin.Begin); | ||
|
|
||
| return Disposable.Create(() => stream.Seek(oldPosition, SeekOrigin.Begin)); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.