Conversation
…es, and WatchAllProperties Agent-Logs-Url: https://github.com/Tyrrrz/PowerKit/sessions/f23ebea3-26c0-4bf6-9aff-bb14b3a613dc Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
…pertyChanged Agent-Logs-Url: https://github.com/Tyrrrz/PowerKit/sessions/c606f958-41e3-4d95-a9ad-57c68f26fa44 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Tyrrrz/PowerKit/sessions/5773a0f4-234a-4d9c-8205-69902444887c Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Ports INotifyPropertyChanged “watch” helpers into PowerKit as source-only extension members, enabling lightweight property-change subscriptions that return IDisposable for easy unsubscription.
Changes:
- Added
WatchProperty,WatchProperties, andWatchAllPropertiesextension members forINotifyPropertyChanged. - Added comprehensive unit tests covering change notifications, initial firing, and disposal/unsubscription behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| PowerKit/Extensions/NotifyPropertyChangedExtensions.cs | Implements the new watch/subscription extension members over INotifyPropertyChanged. |
| PowerKit.Tests/Extensions/NotifyPropertyChangedExtensionsTests.cs | Adds tests validating callback firing behavior and unsubscription via IDisposable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## prime #63 +/- ##
==========================================
- Coverage 94.89% 94.47% -0.43%
==========================================
Files 120 122 +2
Lines 2332 2425 +93
Branches 177 193 +16
==========================================
+ Hits 2213 2291 +78
- Misses 85 95 +10
- Partials 34 39 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tialValue subscription leak Agent-Logs-Url: https://github.com/Tyrrrz/PowerKit/sessions/88b9c9cd-9f7c-4a20-8c23-0ab70970d7c0 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…; init disposable early Agent-Logs-Url: https://github.com/Tyrrrz/PowerKit/sessions/a15979aa-5283-4435-b293-e7bbdcc55a2f Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot drop the try/catch around |
Agent-Logs-Url: https://github.com/Tyrrrz/PowerKit/sessions/05d3dcbc-9e4f-4b23-bfe1-eb3cf1c2e10e Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
watchInitialValuecallback in all three methods (WatchProperty,WatchProperties,WatchAllProperties)Disposable.Create(...)directly at end of each method