Skip to content

Add ParseOrDefault overloads for all ParseOrNull extension types#43

Merged
Tyrrrz merged 1 commit intoprimefrom
copilot/add-parseordefault-methods
Apr 17, 2026
Merged

Add ParseOrDefault overloads for all ParseOrNull extension types#43
Tyrrrz merged 1 commit intoprimefrom
copilot/add-parseordefault-methods

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 17, 2026

Each ParseOrNull extension returns null on failure, but callers often want a fallback value instead of a nullable. This adds ParseOrDefault overloads for all 9 types that return the caller-supplied defaultValue (defaulting to default(T)) rather than null.

Changes

  • Extension methods (bool, int, long, double, decimal, Guid, TimeSpan, DateTime, DateTimeOffset):
    • Simple overload: ParseOrDefault(string? str, T defaultValue = default)
    • Format-parameterized overload where applicable (mirrors the existing ParseOrNull overload with format/style args, defaultValue appended as last optional param)
    • All delegate to the corresponding ParseOrNull via ?? defaultValue
  • Tests: ParseOrDefault_Test added to each extension test class covering success, failure with implicit default, and failure with explicit default

Example

// Before: nullable unwrap required
int value = int.ParseOrNull("abc") ?? -1;

// After: direct non-nullable result
int value = int.ParseOrDefault("abc", -1);  // -1
int zero  = int.ParseOrDefault("abc");      // 0

// Also works with format parameters
int hex = int.ParseOrDefault("FF", NumberStyles.HexNumber, null, -1);

@Tyrrrz Tyrrrz marked this pull request as ready for review April 17, 2026 10:25
Copilot AI review requested due to automatic review settings April 17, 2026 10:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 91.46341% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.48%. Comparing base (a15a0de) to head (65b9bbf).
⚠️ Report is 1 commits behind head on prime.

Files with missing lines Patch % Lines
PowerKit/Extensions/DateTimeExtensions.cs 50.00% 1 Missing ⚠️
PowerKit/Extensions/DateTimeOffsetExtensions.cs 50.00% 1 Missing ⚠️
PowerKit/Extensions/DecimalExtensions.cs 50.00% 1 Missing ⚠️
PowerKit/Extensions/DoubleExtensions.cs 50.00% 1 Missing ⚠️
PowerKit/Extensions/IntExtensions.cs 50.00% 1 Missing ⚠️
PowerKit/Extensions/LongExtensions.cs 50.00% 1 Missing ⚠️
PowerKit/Extensions/TimeSpanExtensions.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            prime      #43      +/-   ##
==========================================
- Coverage   94.63%   94.48%   -0.16%     
==========================================
  Files          82       82              
  Lines        1623     1705      +82     
  Branches      135      135              
==========================================
+ Hits         1536     1611      +75     
- Misses         65       72       +7     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds ParseOrDefault companion overloads to the existing ParseOrNull parsing helpers, letting callers specify a fallback value (defaulting to default(T)) instead of working with nullable results.

Changes:

  • Added ParseOrDefault(...) overloads for bool, int, long, double, decimal, Guid, TimeSpan, DateTime, and DateTimeOffset (including format/style/provider variants where applicable).
  • Implemented all ParseOrDefault methods by delegating to ParseOrNull(...) ?? defaultValue.
  • Added ParseOrDefault_Test coverage to each corresponding test class.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
PowerKit/Extensions/BoolExtensions.cs Adds bool.ParseOrDefault(string?, bool) wrapper over ParseOrNull.
PowerKit/Extensions/IntExtensions.cs Adds int.ParseOrDefault (simple + styles/provider overload).
PowerKit/Extensions/LongExtensions.cs Adds long.ParseOrDefault (simple + styles/provider overload).
PowerKit/Extensions/DoubleExtensions.cs Adds double.ParseOrDefault (simple + styles/provider overload).
PowerKit/Extensions/DecimalExtensions.cs Adds decimal.ParseOrDefault (simple + styles/provider overload).
PowerKit/Extensions/GuidExtensions.cs Adds Guid.ParseOrDefault(string?, Guid) wrapper over ParseOrNull.
PowerKit/Extensions/TimeSpanExtensions.cs Adds TimeSpan.ParseOrDefault (simple + format provider overload).
PowerKit/Extensions/DateTimeExtensions.cs Adds DateTime.ParseOrDefault (simple + provider/styles overload).
PowerKit/Extensions/DateTimeOffsetExtensions.cs Adds DateTimeOffset.ParseOrDefault (simple + provider/styles overload).
PowerKit.Tests/BoolExtensionsTests.cs Adds ParseOrDefault_Test for bool parsing fallback behavior.
PowerKit.Tests/IntExtensionsTests.cs Adds ParseOrDefault_Test for int parsing fallback behavior.
PowerKit.Tests/LongExtensionsTests.cs Adds ParseOrDefault_Test for long parsing fallback behavior.
PowerKit.Tests/DoubleExtensionsTests.cs Adds ParseOrDefault_Test for double parsing fallback behavior.
PowerKit.Tests/DecimalExtensionsTests.cs Adds ParseOrDefault_Test for decimal parsing fallback behavior.
PowerKit.Tests/GuidExtensionsTests.cs Adds ParseOrDefault_Test for Guid parsing fallback behavior.
PowerKit.Tests/TimeSpanExtensionsTests.cs Adds ParseOrDefault_Test for TimeSpan parsing fallback behavior.
PowerKit.Tests/DateTimeExtensionsTests.cs Adds ParseOrDefault_Test for DateTime parsing fallback behavior.
PowerKit.Tests/DateTimeOffsetExtensionsTests.cs Adds ParseOrDefault_Test for DateTimeOffset parsing fallback behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants