-
Notifications
You must be signed in to change notification settings - Fork 1
Add VersionExtensions.ToSemanticString() #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
da1094f
Add VersionExtensions.ToSemanticString() and tests
Copilot e6059c9
Merge VersionExtensions tests into a single test method
Copilot 4c30a34
Update PowerKit/Extensions/VersionExtensions.cs
Tyrrrz 84922a8
Update PowerKit.Tests/VersionExtensionsTests.cs
Tyrrrz cc31863
Update PowerKit/Extensions/VersionExtensions.cs
Tyrrrz bd0957f
Fix CSharpier formatting in VersionExtensions.cs
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| using System; | ||
| using FluentAssertions; | ||
| using PowerKit.Extensions; | ||
| using Xunit; | ||
|
|
||
| namespace PowerKit.Tests; | ||
|
|
||
| public class VersionExtensionsTests | ||
| { | ||
| [Fact] | ||
| public void ToSemanticString_Test() | ||
| { | ||
| new Version(1, 2).ToSemanticString().Should().Be("1.2"); | ||
| new Version(1, 2, 3).ToSemanticString().Should().Be("1.2.3"); | ||
| new Version(1, 2, 3, 4).ToSemanticString().Should().Be("1.2.3.4"); | ||
| new Version(1, 2, 3, 0).ToSemanticString().Should().Be("1.2.3"); | ||
| } | ||
|
Tyrrrz marked this conversation as resolved.
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #nullable enable | ||
| using System; | ||
| using System.Diagnostics.CodeAnalysis; | ||
|
|
||
| namespace PowerKit.Extensions; | ||
|
|
||
| #if !POWERKIT_INCLUDE_COVERAGE | ||
| [ExcludeFromCodeCoverage] | ||
| #endif | ||
| internal static class VersionExtensions | ||
| { | ||
| extension(Version version) | ||
| { | ||
| /// <summary> | ||
| /// Formats the version as a semantic version string, omitting the revision component if it is not set or is zero. | ||
| /// </summary> | ||
| public string ToSemanticString() => | ||
| version.Build < 0 ? version.ToString(2) | ||
| : version.Revision <= 0 ? version.ToString(3) | ||
| : version.ToString(); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.