-
Notifications
You must be signed in to change notification settings - Fork 1
Add Encoding.Utf8WithoutBom static extension property #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6a97b1a
feat: add Encoding.Utf8WithoutBom extension
Copilot 70d4ecb
test: fix test method naming consistency
Copilot f1612c0
Update EncodingExtensions.cs
Tyrrrz 16af99f
test: replace property checks with functional encoding/decoding test
Copilot 210164c
Update PowerKit/Extensions/EncodingExtensions.cs
Tyrrrz 6633d98
revert: remove Encoding.ReadOnly() wrapper (method doesn't exist)
Copilot 0cb2107
Merge remote-tracking branch 'origin/prime' into copilot/add-encoding…
Copilot 0f4e329
refactor: replace ZipArchiveEntryExtensions.Utf8NoBom with Encoding.U…
Copilot 97c15d9
fix: wrap ZipArchiveEntryExtensions in NET40+ guard; reads use Encodi…
Copilot 6a80d70
Update ZipArchiveEntryExtensions.cs
Tyrrrz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| using System.Text; | ||
| using FluentAssertions; | ||
| using PowerKit.Extensions; | ||
| using Xunit; | ||
|
|
||
| namespace PowerKit.Tests; | ||
|
|
||
| public class EncodingExtensionsTests | ||
| { | ||
| [Fact] | ||
| public void Utf8WithoutBom_Test() | ||
| { | ||
| // Arrange | ||
| var text = "hello, world! 🌍"; | ||
|
|
||
| // Act | ||
| var bytes = Encoding.Utf8WithoutBom.GetBytes(text); | ||
|
|
||
| // Assert | ||
| Encoding.UTF8.GetString(bytes).Should().Be(text); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| using System.Text; | ||
|
|
||
| namespace PowerKit.Extensions; | ||
|
|
||
| file static class EncodingEx | ||
| { | ||
| public static Encoding Utf8WithoutBom { get; } = new UTF8Encoding(false); | ||
| } | ||
|
|
||
| internal static class EncodingExtensions | ||
| { | ||
| extension(Encoding) | ||
| { | ||
| /// <summary> | ||
| /// Gets an instance of the UTF-8 encoding that does not emit a byte order mark (BOM). | ||
| /// </summary> | ||
| public static Encoding Utf8WithoutBom => EncodingEx.Utf8WithoutBom; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.