-
Notifications
You must be signed in to change notification settings - Fork 1
Add File.TryDelete and Directory.TryDelete returning bool #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fd17d9b
Add File.TryDelete and Directory.TryDelete returning bool
Copilot b81d643
Fix TryDelete_NonExistingFile_Test to use non-existent path
Copilot 8adedd0
Rename test methods for consistency
Tyrrrz b77acb1
Update FileExtensionsTests.cs
Tyrrrz f03a7eb
Update PowerKit/Extensions/FileExtensions.cs
Tyrrrz 9f32581
Update PowerKit.Tests/DirectoryExtensionsTests.cs
Tyrrrz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| using System.IO; | ||
| using FluentAssertions; | ||
| using PowerKit; | ||
| using PowerKit.Extensions; | ||
| using Xunit; | ||
|
|
||
| namespace PowerKit.Tests; | ||
|
|
||
| public class DirectoryExtensionsTests | ||
| { | ||
| [Fact] | ||
| public void TryDelete_Test() | ||
| { | ||
| // Arrange | ||
| using var tempDir = TempDirectory.Create(); | ||
|
|
||
| // Act | ||
| var result = Directory.TryDelete(tempDir.Path); | ||
|
|
||
| // Assert | ||
| result.Should().BeTrue(); | ||
| Directory.Exists(tempDir.Path).Should().BeFalse(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TryDelete_NonExisting_Test() | ||
| { | ||
| // Act | ||
| var result = Directory.TryDelete(Path.Combine(Path.GetTempPath(), Path.GetRandomFileName())); | ||
|
|
||
| // Assert | ||
| result.Should().BeFalse(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TryDelete_NonEmpty_Test() | ||
| { | ||
| // Arrange | ||
| using var tempDir = TempDirectory.Create(); | ||
| File.WriteAllText(Path.Combine(tempDir.Path, "file.txt"), "hello"); | ||
|
|
||
| // Act | ||
| var result = Directory.TryDelete(tempDir.Path, recursive: false); | ||
|
|
||
| // Assert | ||
| result.Should().BeFalse(); | ||
| Directory.Exists(tempDir.Path).Should().BeTrue(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TryDelete_NonEmpt_Recursive_Test() | ||
| { | ||
| // Arrange | ||
| using var tempDir = TempDirectory.Create(); | ||
| File.WriteAllText(Path.Combine(tempDir.Path, "file.txt"), "hello"); | ||
|
|
||
| // Act | ||
| var result = Directory.TryDelete(tempDir.Path, recursive: true); | ||
|
|
||
| // Assert | ||
| result.Should().BeTrue(); | ||
| Directory.Exists(tempDir.Path).Should().BeFalse(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| using System.IO; | ||
|
|
||
| namespace PowerKit.Extensions; | ||
|
|
||
| internal static class DirectoryExtensions | ||
| { | ||
| extension(Directory) | ||
| { | ||
| /// <summary> | ||
| /// Attempts to delete the directory at the specified path. | ||
| /// Returns <see langword="true" /> if the directory was successfully deleted, or <see langword="false" /> if an error occurred. | ||
| /// </summary> | ||
| public static bool TryDelete(string path, bool recursive = false) | ||
| { | ||
| try | ||
| { | ||
| Directory.Delete(path, recursive); | ||
| return true; | ||
| } | ||
| catch | ||
| { | ||
| return false; | ||
| } | ||
|
Tyrrrz marked this conversation as resolved.
|
||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.