Add CultureInfo.GetParents() and CultureInfo.GetSelfAndParents() extensions#18
Merged
Add CultureInfo.GetParents() and CultureInfo.GetSelfAndParents() extensions#18
Conversation
Agent-Logs-Url: https://github.com/Tyrrrz/PowerKit/sessions/b6e41ae8-72b3-412b-b3a4-20a392a1f576 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Tyrrrz
April 14, 2026 09:48
View session
Tyrrrz
approved these changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CultureInfo traversal helpers to PowerKit, enabling consumers to enumerate a culture’s ancestor chain (and optionally include the culture itself) in a consistent, lazy manner.
Changes:
- Added
CultureInfo.GetParents()to enumerate parent cultures up toCultureInfo.InvariantCulture(exclusive for invariant itself). - Added
CultureInfo.GetSelfAndParents()to enumerate the culture followed by its parents. - Added unit tests covering both methods and key cases (
en-US,en, andInvariantCulture).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PowerKit/Extensions/CultureInfoExtensions.cs | Introduces the two new CultureInfo extension methods for hierarchy traversal. |
| PowerKit.Tests/CultureInfoExtensionsTests.cs | Adds tests validating expected traversal sequences and invariant behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new
CultureInfoextension methods for traversing the culture hierarchy.GetParents()— yields ancestors from immediate parent up toInvariantCulture; returns empty sequence forInvariantCultureitselfGetSelfAndParents()— yields the culture itself followed byGetParents()