Skip to content

Replace Reference/PackageDependencies feature checks with ReferencePath filename checks #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyrrrz merged 2 commits into from
Mar 2, 2026
Merged

Replace Reference/PackageDependencies feature checks with ReferencePath filename checks #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38272f5
Initial plan
Copilot Mar 2, 2026
90d89c1
Replace Reference/PackageDependencies checks with ReferencePath check…
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 16 additions & 79 deletions PolyShim/PolyShim.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,7 @@

<FeatureArrayPool>false</FeatureArrayPool>
<FeatureArrayPool
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'System.Buffers'))"
>true</FeatureArrayPool
>
<FeatureArrayPool
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'System.Buffers'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.Buffers'))"
>true</FeatureArrayPool
>
<FeatureArrayPool
Expand All @@ -45,11 +41,7 @@

<FeatureAsyncInterfaces>false</FeatureAsyncInterfaces>
<FeatureAsyncInterfaces
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Bcl.AsyncInterfaces'))"
>true</FeatureAsyncInterfaces
>
<FeatureAsyncInterfaces
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Bcl.AsyncInterfaces'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'Microsoft.Bcl.AsyncInterfaces'))"
>true</FeatureAsyncInterfaces
>
<FeatureAsyncInterfaces
Expand All @@ -66,19 +58,11 @@

<FeatureHashCode>false</FeatureHashCode>
<FeatureHashCode
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'System.HashCode'))"
>true</FeatureHashCode
>
<FeatureHashCode
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'System.HashCode'))"
>true</FeatureHashCode
>
<FeatureHashCode
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Bcl.HashCode'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.HashCode'))"
>true</FeatureHashCode
>
<FeatureHashCode
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Bcl.HashCode'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'Microsoft.Bcl.HashCode'))"
>true</FeatureHashCode
>
<FeatureHashCode
Expand All @@ -95,19 +79,11 @@

<FeatureHttpClient>false</FeatureHttpClient>
<FeatureHttpClient
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'System.Net.Http'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.Net.Http'))"
>true</FeatureHttpClient
>
<FeatureHttpClient
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'System.Net.Http'))"
>true</FeatureHttpClient
>
<FeatureHttpClient
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Net.Http'))"
>true</FeatureHttpClient
>
<FeatureHttpClient
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Net.Http'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'Microsoft.Net.Http'))"
>true</FeatureHttpClient
>
<FeatureHttpClient
Expand All @@ -124,11 +100,7 @@

<FeatureIndexRange>false</FeatureIndexRange>
<FeatureIndexRange
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Bcl.Memory'))"
>true</FeatureIndexRange
>
<FeatureIndexRange
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Bcl.Memory'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'Microsoft.Bcl.Memory'))"
>true</FeatureIndexRange
>
<FeatureIndexRange
Expand All @@ -145,23 +117,16 @@

<FeatureManagement>false</FeatureManagement>
<FeatureManagement
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'System.Management'))"
>true</FeatureManagement
>
<FeatureManagement
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'System.Management'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.Management'))"
>true</FeatureManagement
>
<DefineConstants Condition="$(FeatureManagement)"
>$(DefineConstants);FEATURE_MANAGEMENT</DefineConstants
>

<FeatureMemory>false</FeatureMemory>
<FeatureMemory Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'System.Memory'))"
>true</FeatureMemory
>
<FeatureMemory
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'System.Memory'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.Memory'))"
>true</FeatureMemory
>
<FeatureMemory
Expand All @@ -178,11 +143,7 @@

<FeatureProcess>false</FeatureProcess>
<FeatureProcess
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'System.Diagnostics.Process'))"
>true</FeatureProcess
>
<FeatureProcess
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'System.Diagnostics.Process'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.Diagnostics.Process'))"
>true</FeatureProcess
>
<FeatureProcess
Expand All @@ -203,11 +164,7 @@

<FeatureRuntimeInformation>false</FeatureRuntimeInformation>
<FeatureRuntimeInformation
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'System.Runtime.InteropServices.RuntimeInformation'))"
>true</FeatureRuntimeInformation
>
<FeatureRuntimeInformation
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'System.Runtime.InteropServices.RuntimeInformation'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.Runtime.InteropServices.RuntimeInformation'))"
>true</FeatureRuntimeInformation
>
<FeatureRuntimeInformation
Expand All @@ -228,19 +185,11 @@

<FeatureTask>false</FeatureTask>
<FeatureTask
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'System.Threading.Tasks'))"
>true</FeatureTask
>
<FeatureTask
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'System.Threading.Tasks'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.Threading.Tasks'))"
>true</FeatureTask
>
<FeatureTask
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Bcl.Async'))"
>true</FeatureTask
>
<FeatureTask
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Bcl.Async'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'Microsoft.Bcl.Async'))"
>true</FeatureTask
>
<FeatureTask
Expand All @@ -259,11 +208,7 @@

<FeatureValueTask>false</FeatureValueTask>
<FeatureValueTask
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'System.Threading.Tasks.Extensions'))"
>true</FeatureValueTask
>
<FeatureValueTask
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'System.Threading.Tasks.Extensions'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.Threading.Tasks.Extensions'))"
>true</FeatureValueTask
>
<FeatureValueTask
Expand All @@ -280,11 +225,7 @@

<FeatureValueTuple>false</FeatureValueTuple>
<FeatureValueTuple
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'System.ValueTuple'))"
>true</FeatureValueTuple
>
<FeatureValueTuple
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'System.ValueTuple'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.ValueTuple'))"
>true</FeatureValueTuple
>
<FeatureValueTuple
Expand All @@ -305,11 +246,7 @@

<FeatureTimeProvider>false</FeatureTimeProvider>
<FeatureTimeProvider
Condition="@(Reference-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Bcl.TimeProvider'))"
>true</FeatureTimeProvider
>
<FeatureTimeProvider
Condition="@(PackageDependencies-&gt;AnyHaveMetadataValue('Identity', 'Microsoft.Bcl.TimeProvider'))"
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'Microsoft.Bcl.TimeProvider'))"
>true</FeatureTimeProvider
>
<FeatureTimeProvider
Expand Down
Loading