Add polyfills for `RandomNumberGenerator` class and `Fill(Span<byte>)` method by Copilot · Pull Request #76 · Tyrrrz/PolyShim

Copilot · 2026-02-17T14:38:29Z

Implementation Details

This PR adds polyfills to enable RandomNumberGenerator.Fill(Span<byte>) functionality across all target frameworks, including older .NET Standard versions where the RandomNumberGenerator class doesn't exist.

RandomNumberGenerator Class Polyfill (NetCore10)

For .NET Standard < 1.3, a complete polyfill of the RandomNumberGenerator abstract class is provided in PolyShim/NetCore10/RandomNumberGenerator.cs that:

Wraps Random for compatibility (not cryptographically secure on these platforms as System.Security.Cryptography types are not available)
Implements proper IDisposable pattern
Provides minimal functionality required for the Fill method
Placed in NetCore10 directory as it's a base type, not a NetCore21-specific feature

Fill Method Polyfill (NetCore21)

The Fill(Span<byte>) method polyfill in PolyShim/NetCore21/RandomNumberGenerator.cs:

Creates a temporary byte array and fills it using the existing GetBytes method
Copies the result to the target span
Includes empty span fast-path optimization
Uses try-finally with explicit IDisposable cast for .NET Framework 3.5 compatibility
Buffer allocation moved inside try block for proper exception handling

Signature Generation Fix

Fixed the signature generation script (List-Signatures.ps1) to include abstract as an optional class modifier in the regex pattern. This bug was preventing abstract classes from being detected, which affected both RandomNumberGenerator and OSPlatformAttribute. The Types count in Signatures.md now correctly reflects 76 types (increased from 74).

This enables modern Span-based random number generation APIs on all .NET Standard versions, even where the infrastructure didn't originally exist. Note that on .NET Standard < 1.3, the random number generation uses Random rather than cryptographically secure methods due to platform limitations.

Original prompt

can you either edit the existing PR (#73) or recreate it, incorporating the provided review comments?

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

…empty span test Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

…rtion Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Tyrrrz

@copilot

Tyrrrz · 2026-02-17T14:59:28Z

PolyShim.Tests/NetCore21/RandomNumberGeneratorTests.cs

+        // Verify that not all bytes are zero (cryptographic RNG should produce non-zero data)
+        // Note: Theoretically, a crypto RNG could produce all zeros (probability: 2^-128),
+        // but this is astronomically unlikely in practice


End sentences with a period

Done in 981b9ca

Tyrrrz · 2026-02-17T14:59:55Z

PolyShim.Tests/NetCore21/RandomNumberGeneratorTests.cs

+        // Verify that not all bytes are zero (cryptographic RNG should produce non-zero data)
+        // Note: Theoretically, a crypto RNG could produce all zeros (probability: 2^-128),
+        // but this is astronomically unlikely in practice
+        buffer.Should().NotBeEquivalentTo(new byte[16]);


I think it's cleaner to check directly for zeroes

Changed to span.ToArray().Should().Contain(b => b != 0) in 981b9ca

Tyrrrz · 2026-02-17T15:00:30Z

PolyShim.Tests/NetCore21/RandomNumberGeneratorTests.cs

+        var buffer = new byte[16];
+        var span = new Span<byte>(buffer);


First expression can be inlined into the second since we don't use the buffer array separately

Inlined in 981b9ca

Tyrrrz · 2026-02-17T15:00:58Z

PolyShim.Tests/NetCore21/RandomNumberGeneratorTests.cs

+    {
+        // Arrange
+        var buffer = new byte[0];
+        var span = new Span<byte>(buffer);


Just new Span<>() should do?

Changed to new Span<byte>() in 981b9ca

Tyrrrz · 2026-02-17T15:01:30Z

PolyShim/NetCore21/RandomNumberGenerator.cs

@@ -0,0 +1,33 @@
+#if (NETCOREAPP && !NETCOREAPP2_1_OR_GREATER) || (NETFRAMEWORK && NET40_OR_GREATER) || (NETSTANDARD && NETSTANDARD1_3_OR_GREATER && !NETSTANDARD2_1_OR_GREATER)


Why the .net std 1.3 limitation? If it's because the class itself doesn't exist, we can create it.

Removed the NETSTANDARD1_3 limitation and used nested #if !NETSTANDARD || NETSTANDARD1_3_OR_GREATER to conditionally include when the class exists, matching the pattern in Path.cs. In 981b9ca

Tyrrrz · 2026-02-17T15:02:24Z

PolyShim/NetCore21/RandomNumberGenerator.cs

+                return;
+
+            var buffer = new byte[data.Length];
+            using (var rng = RandomNumberGenerator.Create())


Why not an implicit scoped using here?

Changed to try-finally with explicit Dispose() for compatibility with net35 where RandomNumberGenerator doesn't work properly with using statements. In 981b9ca

…ions, use try-finally for disposal Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Tyrrrz

@copilot

Tyrrrz · 2026-02-17T15:11:59Z

PolyShim/NetCore21/RandomNumberGenerator.cs

+
+            var buffer = new byte[data.Length];
+            var rng = RandomNumberGenerator.Create();
+            try


Oh I meant a using statement that ends with a semicolon and doesn't use curly braces.

Changed to using var scoped declaration with conditional compilation to handle net35 compatibility in 1bf1f0c

Why the net35 exclusion? It should work the same everywhere @copilot

Removed the NET35 conditional by explicitly casting to IDisposable in the using statement, which works across all frameworks in 5c023b4

… for net35 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot

Pull request overview

This PR adds a polyfill for RandomNumberGenerator.Fill(Span<byte>) to provide compatibility with .NET Framework and older .NET Standard versions. The implementation creates a temporary byte array, fills it with random data using the existing GetBytes method, and copies the result to the target span.

Changes:

Added RandomNumberGenerator.Fill(Span<byte>) polyfill with proper compilation guards and platform-specific disposal patterns
Updated signature documentation to reflect the new member
Added comprehensive tests for both non-empty and empty span scenarios

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
PolyShim/Signatures.md	Updated totals and added documentation entry for the new Fill method
PolyShim/NetCore21/RandomNumberGenerator.cs	Implemented the Fill polyfill with empty span fast-path and NET35-compatible disposal
PolyShim.Tests/NetCore21/RandomNumberGeneratorTests.cs	Added tests validating Fill behavior for both empty and non-empty spans

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Tyrrrz

@copilot

Tyrrrz · 2026-02-17T15:28:03Z

PolyShim/NetCore21/RandomNumberGenerator.cs

@@ -0,0 +1,46 @@
+#if (NETCOREAPP && !NETCOREAPP2_1_OR_GREATER) || (NETFRAMEWORK) || (NETSTANDARD && !NETSTANDARD2_1_OR_GREATER)


How do we get away with these boundaries if the class doesn't exist on some older targets?

The nested #if !NETSTANDARD || NETSTANDARD1_3_OR_GREATER on line 10 excludes the entire class definition for netstandard < 1.3 where RandomNumberGenerator doesn't exist. For those targets, this file compiles to empty content, so the polyfill simply isn't available (which is correct since both the class and Span don't exist there).

We provide Span for all targets, even net std 1.0. can we just create a polyfill for the Random number generator class for net std <1.3? It can just contain the bare minimum required functionality to work with our Fill method.

Added RandomNumberGenerator polyfill for netstandard < 1.3 that wraps RNGCryptoServiceProvider using reflection in 0d9a36a

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Tyrrrz

@copilot

Tyrrrz · 2026-02-17T15:44:03Z

PolyShim/NetCore21/RandomNumberGenerator.cs

+namespace System.Security.Cryptography;
+
+[ExcludeFromCodeCoverage]
+internal abstract class RandomNumberGenerator : IDisposable


Move this into its own appropriate file. This class wasn't introduced in net core 2.1.

Moved to PolyShim/NetCore10/RandomNumberGenerator.cs in 1207292

Tyrrrz · 2026-02-17T15:44:57Z

PolyShim/NetCore21/RandomNumberGenerator.cs

+
+    protected virtual void Dispose(bool disposing) { }
+
+    private sealed class RNGCryptoServiceProviderWrapper : RandomNumberGenerator


Don't use reflection. If there's no way to recreate the functionality of RNGCryptoServiceProvider, just wrap Random

Replaced with Random wrapper in 1207292

Tyrrrz · 2026-02-17T15:45:21Z

PolyShim/NetCore21/RandomNumberGenerator.cs

+            }
+            finally
+            {
+                ((IDisposable)rng).Dispose();


Explain in a comment why this cast is necessary

Added comment explaining it's needed for .NET Framework 3.5 compatibility in 1207292

…apper, add IDisposable cast comment Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Tyrrrz

@copilot

Tyrrrz · 2026-02-17T15:52:44Z

PolyShim/NetCore10/RandomNumberGenerator.cs

+
+        public override void GetBytes(byte[] data)
+        {
+            _random.NextBytes(data);


Use arrow method

Changed to arrow method in 46d1155

Tyrrrz · 2026-02-17T15:53:04Z

PolyShim/NetCore10/RandomNumberGenerator.cs

+        GC.SuppressFinalize(this);
+    }
+
+    protected virtual void Dispose(bool disposing) { }


Move this above the other Dispose

Moved in 46d1155

Tyrrrz · 2026-02-17T15:53:48Z

PolyShim/Signatures.md


- **Total:** 340
+- **Total:** 341
 - **Types:** 74


Why did this not increase?

The RandomNumberGenerator class polyfill is only active for netstandard < 1.3 (conditional compilation), so the signature generation script doesn't detect it when running on netstandard2.0 target where it generates the Signatures.md file.

That makes no sense. The script scans files as text it doesn't take conditional compilation into account. Are you sure you re-ran the build? Please investigate

You were right - the script does scan as text. The issue was the regex pattern internal\s+(?:(?:readonly|partial|static|sealed|ref)\s+)*(class|...) was missing abstract as an optional modifier. Fixed in a0ca669. The Types count now correctly shows 76 (up from 74) - it detected both RandomNumberGenerator and OSPlatformAttribute which are both abstract classes.

You were right - the script does scan as text. The issue was the regex pattern was missing abstract as an optional modifier. Fixed in a0ca669. Types count increased from 74 to 76 (RandomNumberGenerator and OSPlatformAttribute).

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Tyrrrz

@copilot

Tyrrrz · 2026-02-17T16:02:24Z

PolyShim/NetCore21/RandomNumberGenerator.cs

+            finally
+            {
+                // Explicit cast needed for .NET Framework 3.5 where RandomNumberGenerator
+                // doesn't properly expose IDisposable for using statements


End with a period

Added period in a0ca669

Tyrrrz · 2026-02-17T16:02:57Z

PolyShim/NetCore21/RandomNumberGenerator.cs

+            if (data.Length == 0)
+                return;
+
+            var buffer = new byte[data.Length];


Move this inside try

Moved inside try in a0ca669

Tyrrrz · 2026-02-17T16:03:58Z

PolyShim/Signatures.md


- **Total:** 340
+- **Total:** 341
 - **Types:** 74


That makes no sense. The script scans files as text it doesn't take conditional compilation into account. Are you sure you re-ran the build? Please investigate

Tyrrrz · 2026-02-17T16:04:00Z

PolyShim/Signatures.md


- **Total:** 340
+- **Total:** 341
 - **Types:** 74


That makes no sense. The script scans files as text it doesn't take conditional compilation into account. Are you sure you re-ran the build? Please investigate

…re script to detect abstract classes Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

codecov · 2026-02-17T16:17:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (7585585) to head (a0ca669).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@     Coverage Diff      @@
##   master   #76   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Initial plan

dc0f73a

Copilot AI assigned Copilot and Tyrrrz Feb 17, 2026

Copilot started work on behalf of Tyrrrz February 17, 2026 14:38 View session

Tyrrrz added the enhancement New feature or request label Feb 17, 2026

Copilot AI and others added 4 commits February 17, 2026 14:42

Add RandomNumberGenerator.Fill polyfill with review feedback addressed

b26a09a

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Address code review feedback: move CopyTo inside using block and add …

bce162b

…empty span test Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Add null check for RandomNumberGenerator.Create and improve test asse…

df32acb

…rtion Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Remove unnecessary null check and clarify test assertion comment

d44533d

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Incorporate review comments into PR #73~~ Add RandomNumberGenerator.Fill(Span<byte>) polyfill Feb 17, 2026

Copilot AI requested a review from Tyrrrz February 17, 2026 14:52

Copilot finished work on behalf of Tyrrrz February 17, 2026 14:52

Tyrrrz reviewed Feb 17, 2026

View reviewed changes

Copilot started work on behalf of Tyrrrz February 17, 2026 15:03 View session

Address PR feedback: simplify compilation guards, improve test assert…

981b9ca

…ions, use try-finally for disposal Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot AI requested a review from Tyrrrz February 17, 2026 15:11

Copilot finished work on behalf of Tyrrrz February 17, 2026 15:11

Tyrrrz reviewed Feb 17, 2026

View reviewed changes

Tyrrrz marked this pull request as ready for review February 17, 2026 15:19

Copilot AI review requested due to automatic review settings February 17, 2026 15:19

Copilot started work on behalf of Tyrrrz February 17, 2026 15:20 View session

Use scoped using declaration (using var) with conditional compilation…

1bf1f0c

… for net35 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Copilot AI requested a review from Tyrrrz February 17, 2026 15:25

Copilot finished work on behalf of Tyrrrz February 17, 2026 15:25

Copilot started work on behalf of Tyrrrz February 17, 2026 15:27 View session

Tyrrrz reviewed Feb 17, 2026

View reviewed changes

Tyrrrz changed the title ~~Add RandomNumberGenerator.Fill(Span<byte>) polyfill~~ Add polyfill for RandomNumberGenerator.Fill(Span<byte>) Feb 17, 2026

Remove NET35 conditional by casting to IDisposable in using statement

5c023b4

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot AI requested a review from Tyrrrz February 17, 2026 15:32

Copilot finished work on behalf of Tyrrrz February 17, 2026 15:44

Tyrrrz reviewed Feb 17, 2026

View reviewed changes

Copilot started work on behalf of Tyrrrz February 17, 2026 15:46 View session

Move RandomNumberGenerator class polyfill to NetCore10, use Random wr…

1207292

…apper, add IDisposable cast comment Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot AI requested a review from Tyrrrz February 17, 2026 15:51

Copilot finished work on behalf of Tyrrrz February 17, 2026 15:51

Tyrrrz reviewed Feb 17, 2026

View reviewed changes

Copilot started work on behalf of Tyrrrz February 17, 2026 15:54 View session

Use arrow method for GetBytes, reorder Dispose methods

46d1155

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot AI requested a review from Tyrrrz February 17, 2026 16:00

Copilot finished work on behalf of Tyrrrz February 17, 2026 16:01

Tyrrrz reviewed Feb 17, 2026

View reviewed changes

Copilot started work on behalf of Tyrrrz February 17, 2026 16:05 View session

Move buffer allocation inside try, add period to comment, fix signatu…

a0ca669

…re script to detect abstract classes Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>

Copilot AI requested a review from Tyrrrz February 17, 2026 16:11

Copilot finished work on behalf of Tyrrrz February 17, 2026 16:11

Tyrrrz merged commit 66a278d into master Feb 17, 2026
5 checks passed

Tyrrrz mentioned this pull request Feb 17, 2026

Add polyfills for RandomNumberGenerator.Fill(...) #73

Closed

Tyrrrz deleted the copilot/update-pr-73-with-reviews branch March 4, 2026 16:55

		var buffer = new byte[16];
		var span = new Span<byte>(buffer);

		@@ -0,0 +1,33 @@
		#if (NETCOREAPP && !NETCOREAPP2_1_OR_GREATER) \|\| (NETFRAMEWORK && NET40_OR_GREATER) \|\| (NETSTANDARD && NETSTANDARD1_3_OR_GREATER && !NETSTANDARD2_1_OR_GREATER)

		@@ -0,0 +1,46 @@
		#if (NETCOREAPP && !NETCOREAPP2_1_OR_GREATER) \|\| (NETFRAMEWORK) \|\| (NETSTANDARD && !NETSTANDARD2_1_OR_GREATER)


		protected virtual void Dispose(bool disposing) { }

		private sealed class RNGCryptoServiceProviderWrapper : RandomNumberGenerator

Conversation

Copilot AI commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implementation Details

RandomNumberGenerator Class Polyfill (NetCore10)

Fill Method Polyfill (NetCore21)

Signature Generation Fix

Uh oh!

Tyrrrz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Tyrrrz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Tyrrrz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Tyrrrz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Feb 17, 2026 •

edited

Loading