Conversation
Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors the polyfill extension mechanism by replacing a single shared PolyfillExtensions partial class (with numbered variants) with unique, individually named extension classes following the pattern MemberPolyfills_{Version}_{Type}. This improves code organization and eliminates the need for multiple partial class definitions.
Changes:
- Replaced all
PolyfillExtensions,PolyfillExtensions2, andPolyfillExtensions3partial classes with 98 uniquely namedMemberPolyfills_*classes - Added
[ExcludeFromCodeCoverage]attribute andusing System.Diagnostics.CodeAnalysis;to all polyfill extension classes - Updated PowerShell signature generation script to filter new class naming pattern
- Removed the now-obsolete
PolyfillExtensions.csfile
Reviewed changes
Copilot reviewed 117 out of 117 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PolyShim/PolyfillExtensions.cs | Removed obsolete partial class definitions that are no longer needed |
| PolyShim/List-Signatures.ps1 | Updated regex pattern to skip new MemberPolyfills_* classes in signature generation |
| PolyShim/Net*/*.cs (98 files) | Renamed extension classes from PolyfillExtensions* to MemberPolyfills_{Version}_{Type}, added [ExcludeFromCodeCoverage] attribute and required using directive, removed partial modifier |
| PolyShim/NetCore*/*.cs (attribute files) | Added using System.Diagnostics.CodeAnalysis; directive to attribute definition files for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot remove redundant using directives |
Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Removed redundant Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Plan: Replace PolyfillExtensions with Unique Extension Classes
Summary
Successfully refactored all member polyfill extension classes and cleaned up redundant using directives.
Latest Changes:
using System.Diagnostics.CodeAnalysis;from 21 attribute definition filesSystem.Diagnostics.CodeAnalysisnamespace, so they don't need to import itOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.