Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Dec 3, 2025

No description provided.

…nc(CancellationToken)`, `TextReader.ReadToEndAsync(CancellationToken)`
Copilot AI review requested due to automatic review settings December 3, 2025 17:51
@Tyrrrz Tyrrrz added the enhancement New feature or request label Dec 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds polyfills for three .NET 7.0 APIs related to asynchronous file and text reading operations with cancellation token support: File.ReadLinesAsync, TextReader.ReadLineAsync(CancellationToken), and TextReader.ReadToEndAsync(CancellationToken).

  • Implements TextReader.ReadLineAsync(CancellationToken) and TextReader.ReadToEndAsync(CancellationToken) polyfills for frameworks prior to .NET 7.0
  • Adds two overloads of File.ReadLinesAsync that return IAsyncEnumerable<string> with cancellation support
  • Includes comprehensive test coverage for the new polyfills including cancellation scenarios

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
PolyShim/Signatures.md Updates signature counts and documentation to reflect 4 new polyfilled members
PolyShim/Net70/TextReader.cs Implements ReadLineAsync(CancellationToken) and ReadToEndAsync(CancellationToken) polyfills
PolyShim/Net70/File.cs Implements two ReadLinesAsync overloads with async enumerable return type
PolyShim.Tests/Net70/TextReaderTests.cs Adds tests for TextReader polyfills including cancellation scenarios
PolyShim.Tests/Net70/FileTests.cs Adds basic test for File.ReadLinesAsync functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit f7d8711 into master Dec 3, 2025
11 checks passed
@Tyrrrz Tyrrrz deleted the text-reader-readlinesasync branch December 3, 2025 18:40
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (7ee686f) to head (2633619).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #68   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants