Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Dec 3, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 3, 2025 14:44
@Tyrrrz Tyrrrz added the enhancement New feature or request label Dec 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds polyfill implementations for IntPtr and UIntPtr parsing methods that were introduced in .NET 5.0, enabling their use in older frameworks (pre-.NET 5.0 versions of .NET Core, .NET Framework, and .NET Standard).

Key changes:

  • Added 5 parsing methods for IntPtr: Parse (4 overloads) and TryParse
  • Added 5 parsing methods for UIntPtr: Parse (4 overloads) and TryParse
  • Updated documentation to reflect 10 new method signatures (total count increased from 320 to 330)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
PolyShim/Signatures.md Updated totals and added documentation for 5 new IntPtr methods and 5 new UIntPtr methods targeting .NET 5.0
PolyShim/Net50/IntPtr.cs Implements Parse and TryParse polyfills for IntPtr, delegating to int/long based on pointer size
PolyShim/Net50/UIntPtr.cs Implements Parse and TryParse polyfills for UIntPtr, delegating to uint/ulong based on pointer size

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 72e86a9 into master Dec 3, 2025
11 checks passed
@Tyrrrz Tyrrrz deleted the intptr-parse branch December 3, 2025 14:48
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (e85c8bf) to head (d5c2949).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #65   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants