Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Dec 2, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 2, 2025 15:47
@Tyrrrz Tyrrrz added the enhancement New feature or request label Dec 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds polyfills for Task.Run(...), Task.WhenAll(...), and Task.WhenAny(...) to enable these .NET Core 1.0+ APIs in older frameworks (specifically NET Framework < 4.6 and .NET Standard < 1.3).

  • Adds 8 overloads of Task.Run for executing actions and functions on the thread pool
  • Adds 4 overloads of Task.WhenAll for waiting on multiple tasks
  • Adds 4 overloads of Task.WhenAny for waiting on the first task to complete

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

File Description
PolyShim/Signatures.md Updated signature count from 275 to 291 (added 16 new Task method signatures) and documented all new Task polyfill APIs
PolyShim/NetCore10/Task.cs Implemented 16 Task polyfill methods using Task.Factory.StartNew, ContinueWhenAll, and ContinueWhenAny as the underlying mechanisms

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 28f3002 into master Dec 2, 2025
3 checks passed
@Tyrrrz Tyrrrz deleted the task-basics branch December 2, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants