-
-
Notifications
You must be signed in to change notification settings - Fork 4
Add polyfills for Task.Run(...), Task.WhenAny(...) and Task.WhenAll(...)
#62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds polyfills for Task.Run(...), Task.WhenAll(...), and Task.WhenAny(...) to enable these .NET Core 1.0+ APIs in older frameworks (specifically NET Framework < 4.6 and .NET Standard < 1.3).
- Adds 8 overloads of
Task.Runfor executing actions and functions on the thread pool - Adds 4 overloads of
Task.WhenAllfor waiting on multiple tasks - Adds 4 overloads of
Task.WhenAnyfor waiting on the first task to complete
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| PolyShim/Signatures.md | Updated signature count from 275 to 291 (added 16 new Task method signatures) and documented all new Task polyfill APIs |
| PolyShim/NetCore10/Task.cs | Implemented 16 Task polyfill methods using Task.Factory.StartNew, ContinueWhenAll, and ContinueWhenAny as the underlying mechanisms |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.