Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 30, 2025

No description provided.

…`Random.GetItems(...)`, `Random.Shuffle(...)`, `Random.GetHexString(...)`, `Random.GetString(...)`
Copilot AI review requested due to automatic review settings November 30, 2025 16:33
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 30, 2025
Copilot finished reviewing on behalf of Tyrrrz November 30, 2025 16:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds polyfills for six Random class methods to enable their use in older .NET Framework, .NET Standard, and .NET Core versions. The polyfills target methods introduced in .NET 6.0, 8.0, and 10.0.

  • Implements NextInt64, NextSingle for .NET 6.0 compatibility
  • Implements GetItems, Shuffle for .NET 8.0 compatibility
  • Implements GetHexString, GetString for .NET 10.0 compatibility

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
PolyShim/Signatures.md Updates documentation to reflect 9 new Random method signatures
PolyShim/Net60/Random.cs Adds polyfills for NextInt64 (3 overloads) and NextSingle
PolyShim/Net80/Random.cs Adds polyfills for GetItems and Shuffle
PolyShim/Net100/Random.cs Adds polyfills for GetHexString and GetString (2 overloads)
PolyShim.Tests/Net60/RandomTests.cs Adds tests for NextInt64 and NextSingle methods
PolyShim.Tests/Net80/RandomTests.cs Adds tests for GetItems and Shuffle methods
PolyShim.Tests/Net100/RandomTests.cs Adds tests for GetHexString and GetString methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz requested a review from Copilot November 30, 2025 16:38
Copilot finished reviewing on behalf of Tyrrrz November 30, 2025 16:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit a8ce085 into master Nov 30, 2025
11 checks passed
@Tyrrrz Tyrrrz deleted the random-getitems-etc branch November 30, 2025 16:41
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (3daf267) to head (738c4ce).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #60   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants