Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 30, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 30, 2025 15:50
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 30, 2025
Copilot finished reviewing on behalf of Tyrrrz November 30, 2025 15:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds polyfills for hexadecimal string conversion methods from the Convert class, enabling these .NET 5.0 and .NET 9.0 APIs to be used in earlier framework versions.

  • Implements Convert.FromHexString, Convert.ToHexString (NET 5.0 APIs)
  • Implements Convert.ToHexStringLower (NET 9.0 APIs)
  • Includes comprehensive test coverage for the new polyfills

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
PolyShim/Signatures.md Updated documentation to include 5 new Convert methods with correct version annotations
PolyShim/Net50/Convert.cs Implements FromHexString and ToHexString polyfills with custom hex conversion logic using bitwise operations
PolyShim/Net90/Convert.cs Implements ToHexStringLower by delegating to ToHexString and applying ToLowerInvariant()
PolyShim.Tests/Net50/ConvertTests.cs Adds tests for hex string encoding/decoding including error cases for invalid input
PolyShim.Tests/Net90/ConvertTests.cs Adds tests for lowercase hex string conversion with various input scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 3daf267 into master Nov 30, 2025
5 checks passed
@Tyrrrz Tyrrrz deleted the base64string branch November 30, 2025 16:00
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (b8db144) to head (823aa9f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #59   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants