-
-
Notifications
You must be signed in to change notification settings - Fork 4
Add polyfill for File.AppendAllBytes(...)
#55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a polyfill implementation for the File.AppendAllBytes(string, byte[]) method introduced in .NET 9.0, enabling its use in earlier .NET versions.
Key changes:
- Added synchronous
AppendAllBytesmethod polyfill using FileStream with append mode - Added unit test to verify the method works correctly
- Updated documentation to reflect the new polyfilled member
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| PolyShim/Net90/File.cs | Implements the AppendAllBytes method polyfill using FileStream in append mode with write access |
| PolyShim.Tests/Net90/FileTests.cs | Adds unit test for the new AppendAllBytes method |
| PolyShim/Signatures.md | Updates member count and adds documentation entry for the new polyfilled method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.