Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 17, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 17, 2025 13:26
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 17, 2025
Copilot finished reviewing on behalf of Tyrrrz November 17, 2025 13:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a polyfill for the Path.Join(params string?[]) method introduced in .NET Core 3.0, enabling its use on older framework versions. The implementation refactors the existing EndsInDirectorySeparator method to use a new helper method IsDirectorySeparator, which is then reused in the Join implementation.

  • Introduces a private IsDirectorySeparator(char) helper method for cleaner code reuse
  • Refactors EndsInDirectorySeparator to use expression-bodied syntax with the new helper
  • Implements Path.Join(params string?[]) that concatenates paths with proper separator handling
  • Adds test coverage for the new Join method

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
PolyShim/NetCore30/Path.cs Adds IsDirectorySeparator helper, refactors EndsInDirectorySeparator, and implements Path.Join polyfill with appropriate preprocessor directives for different framework versions
PolyShim.Tests/NetCore30/PathTests.cs Adds Join_Test with three test cases covering path concatenation scenarios including trailing/leading separators and rooted paths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 5aaa9b3 into master Nov 17, 2025
11 checks passed
@Tyrrrz Tyrrrz deleted the path-join branch November 17, 2025 13:30
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (84385aa) to head (8e82480).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #44   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants