Skip to content

Fix BinaryPrimitives being available with System.Memory imported - #132

Merged
Tyrrrz merged 1 commit into
primefrom
bin-prim-system-memory
Jul 13, 2026
Merged

Fix BinaryPrimitives being available with System.Memory imported#132
Tyrrrz merged 1 commit into
primefrom
bin-prim-system-memory

Conversation

@Tyrrrz

@Tyrrrz Tyrrrz commented Jul 13, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 13, 2026 11:53
@Tyrrrz Tyrrrz added the bug Something isn't working label Jul 13, 2026
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.19%. Comparing base (3999e5c) to head (02da4f9).
⚠️ Report is 1 commits behind head on prime.

Additional details and impacted files
@@           Coverage Diff           @@
##            prime     #132   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files         148      148           
  Lines        3981     3981           
  Branches       87       87           
=======================================
  Hits         3949     3949           
  Misses         13       13           
  Partials       19       19           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the compilation guard for the NetCore21 BinaryPrimitives polyfill so it is excluded whenever System.Memory is available (either via target framework support or an explicit System.Memory reference), preventing duplicate type conflicts.

Changes:

  • Replace the TFM-based preprocessor condition with #if !FEATURE_MEMORY for BinaryPrimitives.
  • Align BinaryPrimitives with the existing NetCore21 polyfill gating pattern used by other memory-related shims.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants