Fix BinaryPrimitives being available with System.Memory imported - #132
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prime #132 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 148 148
Lines 3981 3981
Branches 87 87
=======================================
Hits 3949 3949
Misses 13 13
Partials 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the compilation guard for the NetCore21 BinaryPrimitives polyfill so it is excluded whenever System.Memory is available (either via target framework support or an explicit System.Memory reference), preventing duplicate type conflicts.
Changes:
- Replace the TFM-based preprocessor condition with
#if !FEATURE_MEMORYforBinaryPrimitives. - Align
BinaryPrimitiveswith the existingNetCore21polyfill gating pattern used by other memory-related shims.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.