Skip to content

Add HashData/TryHashData/HashDataAsync polyfills for MD5, SHA1, SHA256, SHA384, SHA512 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyrrrz merged 15 commits into from
Apr 21, 2026
Merged

Add HashData/TryHashData/HashDataAsync polyfills for MD5, SHA1, SHA256, SHA384, SHA512 #126

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
96999d5
feat: add HashData/TryHashData/HashDataAsync polyfills for MD5, SHA1,…
Copilot Apr 20, 2026
4d27b63
perf: avoid ToArray() allocation in HashDataAsync by reusing MemorySt…
Copilot Apr 20, 2026
bde7cee
test: replace circular hash assertions with precomputed expected values
Copilot Apr 20, 2026
e00a241
refactor: delegate Net50 hash methods to each other to reduce LOC and…
Copilot Apr 20, 2026
b07dd97
refactor: inline hash bytes, keep only outer-method tests, reorder po…
Copilot Apr 20, 2026
972daa7
rename HashData_Array_Test to HashData_Test in all Net50 test files
Copilot Apr 21, 2026
ded739e
remove inline hash-label comments from tests; move netstandard guard …
Copilot Apr 21, 2026
67e75bb
rename HashDataAsync_Stream_WithDestination_Test to HashDataAsync_Tes…
Copilot Apr 21, 2026
a34d47c
make HashData(byte[]) the primary overload in all 5 Net50 algorithms;…
Copilot Apr 21, 2026
df6bf2f
restore netstandard guard comments in all 10 Net50/Net70 polyfill files
Copilot Apr 21, 2026
3283428
add HashAlgorithm.ComputeHashAsync polyfill; use it in Net70 HashData…
Copilot Apr 21, 2026
8ff61fb
move FEATURE_TASK guard to method level in HashAlgorithm.cs
Copilot Apr 21, 2026
dfb677f
use async/await in ComputeHashAsync polyfill
Copilot Apr 21, 2026
1ee977e
add ConfigureAwait(false) to ComputeHashAsync polyfill
Copilot Apr 21, 2026
c855f2d
Fix formatting: run dotnet format
Copilot Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 113 additions & 0 deletions PolyShim.Tests/Net50/MD5Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
using System;
using System.Security.Cryptography;
using FluentAssertions;
using Xunit;

namespace PolyShim.Tests.Net50;

public class MD5Tests
{
// MD5([1, 2, 3, 4, 5])
private static readonly byte[] ExpectedHash =
Comment thread
Tyrrrz marked this conversation as resolved.
Outdated
[
0x7c,
0xfd,
0xd0,
0x78,
0x89,
0xb3,
0x29,
0x5d,
0x6a,
0x55,
0x09,
0x14,
0xab,
0x35,
0xe0,
0x68,
];

[Fact]
public void HashData_Array_Test()
Comment thread
Tyrrrz marked this conversation as resolved.
Outdated
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };

// Act
var hash = MD5.HashData(data);

// Assert
hash.Should().Equal(ExpectedHash);
}

[Fact]
public void HashData_Span_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };

// Act
var hash = MD5.HashData(data.AsSpan());

// Assert
hash.Should().Equal(ExpectedHash);
}

[Fact]
public void HashData_Span_WithDestination_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[16];

// Act
var bytesWritten = MD5.HashData(data.AsSpan(), destination.AsSpan());

// Assert
bytesWritten.Should().Be(16);
destination.Should().Equal(ExpectedHash);
}

[Fact]
public void HashData_Span_WithDestination_TooSmall_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[8];

// Act & assert
Assert.Throws<ArgumentException>(() => MD5.HashData(data.AsSpan(), destination.AsSpan()));
}

[Fact]
public void TryHashData_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[16];

// Act
var result = MD5.TryHashData(data.AsSpan(), destination.AsSpan(), out var bytesWritten);

// Assert
result.Should().BeTrue();
bytesWritten.Should().Be(16);
destination.Should().Equal(ExpectedHash);
}

[Fact]
public void TryHashData_TooSmall_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[8];

// Act
var result = MD5.TryHashData(data.AsSpan(), destination.AsSpan(), out var bytesWritten);

// Assert
result.Should().BeFalse();
bytesWritten.Should().Be(0);
}
}
117 changes: 117 additions & 0 deletions PolyShim.Tests/Net50/SHA1Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
using System;
using System.Security.Cryptography;
using FluentAssertions;
using Xunit;

namespace PolyShim.Tests.Net50;

public class SHA1Tests
{
// SHA1([1, 2, 3, 4, 5])
private static readonly byte[] ExpectedHash =
[
0x11,
0x96,
0x6a,
0xb9,
0xc0,
0x99,
0xf8,
0xfa,
0xbe,
0xfa,
0xc5,
0x4c,
0x08,
0xd5,
0xbe,
0x2b,
0xd8,
0xc9,
0x03,
0xaf,
];

[Fact]
public void HashData_Array_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };

// Act
var hash = SHA1.HashData(data);

// Assert
hash.Should().Equal(ExpectedHash);
}

[Fact]
public void HashData_Span_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };

// Act
var hash = SHA1.HashData(data.AsSpan());

// Assert
hash.Should().Equal(ExpectedHash);
}

[Fact]
public void HashData_Span_WithDestination_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[20];

// Act
var bytesWritten = SHA1.HashData(data.AsSpan(), destination.AsSpan());

// Assert
bytesWritten.Should().Be(20);
destination.Should().Equal(ExpectedHash);
}

[Fact]
public void HashData_Span_WithDestination_TooSmall_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[10];

// Act & assert
Assert.Throws<ArgumentException>(() => SHA1.HashData(data.AsSpan(), destination.AsSpan()));
}

[Fact]
public void TryHashData_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[20];

// Act
var result = SHA1.TryHashData(data.AsSpan(), destination.AsSpan(), out var bytesWritten);

// Assert
result.Should().BeTrue();
bytesWritten.Should().Be(20);
destination.Should().Equal(ExpectedHash);
}

[Fact]
public void TryHashData_TooSmall_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[10];

// Act
var result = SHA1.TryHashData(data.AsSpan(), destination.AsSpan(), out var bytesWritten);

// Assert
result.Should().BeFalse();
bytesWritten.Should().Be(0);
}
}
131 changes: 131 additions & 0 deletions PolyShim.Tests/Net50/SHA256Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
using System;
using System.Security.Cryptography;
using FluentAssertions;
using Xunit;

namespace PolyShim.Tests.Net50;

public class SHA256Tests
{
// SHA256([1, 2, 3, 4, 5])
private static readonly byte[] ExpectedHash =
[
0x74,
0xf8,
0x1f,
0xe1,
0x67,
0xd9,
0x9b,
0x4c,
0xb4,
0x1d,
0x6d,
0x0c,
0xcd,
0xa8,
0x22,
0x78,
0xca,
0xee,
0x9f,
0x3e,
0x2f,
0x25,
0xd5,
0xe5,
0xa3,
0x93,
0x6f,
0xf3,
0xdc,
0xec,
0x60,
0xd0,
];

[Fact]
public void HashData_Array_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };

// Act
var hash = SHA256.HashData(data);

// Assert
hash.Should().Equal(ExpectedHash);
}

[Fact]
public void HashData_Span_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };

// Act
var hash = SHA256.HashData(data.AsSpan());

// Assert
hash.Should().Equal(ExpectedHash);
}

[Fact]
public void HashData_Span_WithDestination_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[32];

// Act
var bytesWritten = SHA256.HashData(data.AsSpan(), destination.AsSpan());

// Assert
bytesWritten.Should().Be(32);
destination.Should().Equal(ExpectedHash);
}

[Fact]
public void HashData_Span_WithDestination_TooSmall_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[16];

// Act & assert
Assert.Throws<ArgumentException>(() =>
SHA256.HashData(data.AsSpan(), destination.AsSpan())
);
}

[Fact]
public void TryHashData_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[32];

// Act
var result = SHA256.TryHashData(data.AsSpan(), destination.AsSpan(), out var bytesWritten);

// Assert
result.Should().BeTrue();
bytesWritten.Should().Be(32);
destination.Should().Equal(ExpectedHash);
}

[Fact]
public void TryHashData_TooSmall_Test()
{
// Arrange
var data = new byte[] { 1, 2, 3, 4, 5 };
var destination = new byte[16];

// Act
var result = SHA256.TryHashData(data.AsSpan(), destination.AsSpan(), out var bytesWritten);

// Assert
result.Should().BeFalse();
bytesWritten.Should().Be(0);
}
}
Loading