Conversation
…rloads delegate to them Agent-Logs-Url: https://github.com/Tyrrrz/PolyShim/sessions/715cc890-8c16-4ee1-8fb3-41bf327f0073 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prime #124 +/- ##
==========================================
+ Coverage 90.60% 90.76% +0.16%
==========================================
Files 285 285
Lines 4959 4959
Branches 404 404
==========================================
+ Hits 4493 4501 +8
+ Misses 373 366 -7
+ Partials 93 92 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Refactors HttpClient polyfills so the Uri overloads contain the primary implementations and the string overloads delegate to them.
Changes:
- Moved
GetStreamAsync,GetByteArrayAsync, andGetStringAsyncimplementation logic into theUrioverloads - Updated
stringoverloads to delegate toUrioverloads by constructing aUrifrom the input string - Updated docs links/comments to match the new primary overloads
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… BaseAddress compatibility Agent-Logs-Url: https://github.com/Tyrrrz/PolyShim/sessions/d05650b1-31f5-41d3-9725-5b7bfe05aac1 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Previously,
stringoverloads held the implementation andUrioverloads delegated viarequestUri.ToString(). This is backwards —Uriis the richer, more precise type and should be primary.Changes
GetStreamAsync,GetByteArrayAsync,GetStringAsync: moved full implementation into theUrioverloadsstringoverloads now delegate to theirUricounterparts vianew Uri(requestUri)