Conversation
…Async/net40 example Agent-Logs-Url: https://github.com/Tyrrrz/PolyShim/sessions/51487cd5-005f-4617-a680-3417049f66f6 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Tyrrrz
April 17, 2026 09:26
View session
Tyrrrz
approved these changes
Apr 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the documentation example for compatibility packages to demonstrate a real case where adding a Microsoft compatibility package expands PolyShim’s available polyfills (instead of disabling them due to already-provided APIs).
Changes:
- Replaces the
netstandard2.0+Microsoft.Bcl.AsyncInterfacesexample with anet40+Microsoft.Bcl.Asyncexample. - Updates the sample code to show
ValueTask+IAsyncEnumerable<T>usage enabled viaMicrosoft.Bcl.Async(i.e.,FEATURE_TASKbecomes available on net40).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prime #116 +/- ##
==========================================
+ Coverage 90.66% 90.75% +0.08%
==========================================
Files 282 282
Lines 4898 4898
Branches 401 401
==========================================
+ Hits 4441 4445 +4
+ Misses 367 364 -3
+ Partials 90 89 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Microsoft.Bcl.AsyncInterfacesexample was misleading: PolyShim doesn't polyfillIAsyncEnumerable<T>when that package is present (the package provides it directly), so no additional PolyShim polyfills were actually being enabled.Changes
netstandard2.0+Microsoft.Bcl.AsyncInterfaces/Task.WhenEachexample with anet40+Microsoft.Bcl.AsyncexampleMicrosoft.Bcl.AsyncsetsFEATURE_TASK=true, which unlocks PolyShim'sValueTask(FEATURE_TASK && !FEATURE_VALUETASK) andIAsyncEnumerable<T>(FEATURE_TASK && !FEATURE_ASYNCINTERFACES) polyfills — a genuine case of a compatibility package expanding PolyShim's coverage