Skip to content

Fix ManualResetValueTaskSourceCore polyfill missing on netstandard2.0 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyrrrz merged 6 commits into from
Apr 17, 2026
Merged

Fix ManualResetValueTaskSourceCore polyfill missing on netstandard2.0 #115

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad67543
Fix FEATURE_VALUETASK_SOURCES_MANUALRESET incorrectly set for netstan…
Copilot Apr 17, 2026
0172d7f
Merge branch 'prime' into copilot/investigate-issue-185
Tyrrrz Apr 17, 2026
087f463
Inline ManualResetValueTaskSourceCore guard as TFM check, remove FEAT…
Copilot Apr 17, 2026
a431893
Use TFM guard pattern in ManualResetValueTaskSourceCore.cs per review…
Copilot Apr 17, 2026
ce4e01e
Use nested FEATURE_TASK guard instead of NET40_OR_GREATER version check
Copilot Apr 17, 2026
69fe551
Update ManualResetValueTaskSourceCore.cs
Tyrrrz Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion PolyShim/NetCore21/ManualResetValueTaskSourceCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#if FEATURE_TASK
#if !FEATURE_VALUETASK_SOURCES_MANUALRESET
// ManualResetValueTaskSourceCore<T> is only available natively on .NET Core >= 2.1 and .NET Standard >= 2.1.
// The System.Threading.Tasks.Extensions compatibility package does NOT provide this type for
// .NET Standard 2.0 or .NET Framework targets — only IValueTaskSource<T> and related types are included there.
#if !NETCOREAPP2_1_OR_GREATER && !NETSTANDARD2_1_OR_GREATER
Comment thread
Tyrrrz marked this conversation as resolved.
Outdated
#nullable enable
#pragma warning disable CS0436

Expand Down
22 changes: 0 additions & 22 deletions PolyShim/PolyShim.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,28 +260,6 @@
>$(DefineConstants);FEATURE_VALUETASK_SOURCES</DefineConstants
>

<!--
FEATURE_VALUETASK_SOURCES_MANUALRESET: ManualResetValueTaskSourceCore<T> is available.
The compatibility package provides this type on .NET Standard >= 2.0, but not on .NET Framework
or on .NET Standard < 2.0. On .NET Core >= 2.1 and .NET Standard >= 2.1, it is available natively.
-->
<FeatureValueTaskSourcesManualReset>false</FeatureValueTaskSourcesManualReset>
<FeatureValueTaskSourcesManualReset
Condition="$(IsNetCoreApp) AND $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '2.1'))"
>true</FeatureValueTaskSourcesManualReset
>
<FeatureValueTaskSourcesManualReset
Condition="$(IsNetStandard) AND $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '2.1'))"
>true</FeatureValueTaskSourcesManualReset
>
<FeatureValueTaskSourcesManualReset
Condition="$(IsNetStandard) AND $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '2.0')) AND @(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.Threading.Tasks.Extensions'))"
>true</FeatureValueTaskSourcesManualReset
>
<DefineConstants Condition="$(FeatureValueTaskSourcesManualReset)"
>$(DefineConstants);FEATURE_VALUETASK_SOURCES_MANUALRESET</DefineConstants
>

<FeatureValueTuple>false</FeatureValueTuple>
<FeatureValueTuple
Condition="@(ReferencePath-&gt;AnyHaveMetadataValue('Filename', 'System.ValueTuple'))"
Expand Down