Conversation
Agent-Logs-Url: https://github.com/Tyrrrz/PolyShim/sessions/360379ff-dc17-49d4-a5a0-9daa1a21349a Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Tyrrrz/PolyShim/sessions/bc4ff120-f472-42fe-b68b-ff85217ea8a5 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds .NET 5 (net5.0) as an additional test target so the test suite runs on both net5.0 and net10.0 (plus net462 on Windows), and updates CI to install the required .NET SDKs.
Changes:
- Multi-target
PolyShim.Testsfornet5.0andnet10.0(withnet462appended on Windows). - Update the GitHub Actions workflow to install both
5.0.xand10.0.xSDKs for CI runs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PolyShim.Tests/PolyShim.Tests.csproj | Adds net5.0 to TargetFrameworks to run tests against .NET 5 and .NET 10. |
| .github/workflows/main.yml | Passes a multi-version dotnet-version input so CI installs SDKs for both net5.0 and net10.0 test runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prime #112 +/- ##
==========================================
+ Coverage 90.03% 90.88% +0.85%
==========================================
Files 269 269
Lines 4604 4607 +3
Branches 367 378 +11
==========================================
+ Hits 4145 4187 +42
+ Misses 378 337 -41
- Partials 81 83 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot why are we getting 0 tests ran for .NET 5? |
The test host bundled with If testing an older .NET version is the goal, |
|
@copilot let's try net6.0. Unfortunately, net8.0 is too new for our purposes. |
Agent-Logs-Url: https://github.com/Tyrrrz/PolyShim/sessions/e8424fb6-7b0e-45dc-868f-7fd324a3233f Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Adds
net6.0as a test target alongsidenet10.0(andnet462on Windows), and installs both SDKs on CI so thenet6.0test run has its runtime available. (net5.0was skipped becauseMicrosoft.NET.Test.Sdk 17.8.0's test host requires .NET 6+, causing zero tests to be discovered on net5.0.)PolyShim.Tests.csproj:TargetFrameworks→net6.0;net10.0(net6.0 first)main.yml: passesdotnet-versionto the reusable workflow to install both6.0.xand10.0.x;global.jsonstays pinned to10.0.100as the build SDK