Skip to content

Remove explicit Microsoft.SourceLink.GitHub package reference - #24

Merged
Tyrrrz merged 2 commits into
masterfrom
copilot/remove-source-link-package
Mar 2, 2026
Merged

Remove explicit Microsoft.SourceLink.GitHub package reference#24
Tyrrrz merged 2 commits into
masterfrom
copilot/remove-source-link-package

Conversation

Copilot AI commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Since .NET 8 SDK, Source Link support for GitHub-hosted repositories is built into the SDK — the Microsoft.SourceLink.GitHub NuGet package is no longer needed.

Changes

  • JsonExtensions/JsonExtensions.csproj — removed PackageReference for Microsoft.SourceLink.GitHub
  • Directory.Packages.props — removed corresponding PackageVersion entry
Original prompt

Background

Since .NET 8 SDK, Source Link support is built directly into the SDK for GitHub-hosted repositories. It is no longer necessary to explicitly reference the Microsoft.SourceLink.GitHub NuGet package.

Task

Remove all explicit references to Microsoft.SourceLink.GitHub from the project.

In JsonExtensions/JsonExtensions.csproj, remove the following line:

<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="all" />

If there is a corresponding PackageVersion entry for Microsoft.SourceLink.GitHub in Directory.Packages.props (if that file exists), remove that entry too.

Do not make any other changes. The built-in SDK Source Link support will take over automatically.

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@Tyrrrz Tyrrrz added the enhancement New feature or request label Mar 2, 2026
@Tyrrrz
Tyrrrz marked this pull request as ready for review March 2, 2026 11:39
Copilot AI review requested due to automatic review settings March 2, 2026 11:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Mar 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.46%. Comparing base (bc1b34c) to head (90d8ed2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files           8        8           
  Lines         470      470           
  Branches       97       97           
=======================================
  Hits          444      444           
  Misses         12       12           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove explicit references to Microsoft.SourceLink.GitHub Remove explicit Microsoft.SourceLink.GitHub package reference Mar 2, 2026
@Tyrrrz
Tyrrrz merged commit b2cc9c3 into master Mar 2, 2026
7 checks passed
@Tyrrrz
Tyrrrz deleted the copilot/remove-source-link-package branch March 2, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants