Closed
Enforce process ownership: guarantee process termination across all execution paths#340
Conversation
Copilot
AI
changed the title
[WIP] Enforce process ownership: guarantee process termination across all execution paths
Enforce process ownership: guarantee process termination across all execution paths
Jul 26, 2026
An error occurred while trying to automatically change base from
copilot/fix-background-execution-on-exception
to
prime
July 26, 2026 18:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pipe delegate threw an exception, the underlying process was left running in the background. In the worst case (process blocked writing to a full pipe buffer with no reader), this became a permanent deadlock with no way out short of user cancellation.
The new convention: CliWrap takes full ownership of the process it spawns and guarantees it is terminated before any execution method returns or throws, regardless of exit path.
Changes
Command.Execution.csTask.WhenAny(waitTask, pipingTask)to detect early pipe failure, then immediatelyKill()the process before awaiting it — prevents the deadlock where the process is blocked on a full pipe buffer with no readertry/finallywithprocess.Kill()as a belt-and-suspenders guarantee covering any exit path not already handled by the inline killPullEventStreamCommandExtensions.csabandonCts(which let the process keep running in the background when the consumer broke out) withkillCtswired as the forceful cancellation token intoExecuteAsyncawait foreachnow cancelskillCts, killing the process beforeListenAsyncreturnsPushEventStreamCommandExtensions.csDisposable.Nullteardown with akillCts-backed disposable, symmetrical with theListenAsyncfixObserve()subscription (e.g. via.FirstAsync(),.Take(n), or explicitDispose()) now cancelskillCts, killing the underlying processReadme.mdListenAsyncbreak behaviorExample: previously broken, now correct