Skip to content

Use LibraryImport instead of DllImport for proper AOT support #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyrrrz merged 3 commits into from
Mar 20, 2026
Merged

Use LibraryImport instead of DllImport for proper AOT support #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9146bb0
feat: use LibraryImport instead of DllImport for AOT support on net7.0+
Copilot Mar 20, 2026
f83d881
fix: add comment on LibraryImport limitation and unconditional AllowU…
Copilot Mar 20, 2026
4ca9da5
fix: correct comment — source generator omits impl for pre-.NET 7 TFM…
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CliWrap/CliWrap.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))"
>true</IsAotCompatible
>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>

<PropertyGroup>
Expand Down
11 changes: 9 additions & 2 deletions CliWrap/Utils/NativeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,18 @@

namespace CliWrap.Utils;

internal static class NativeMethods
internal static partial class NativeMethods
{
public static class Unix
public static partial class Unix
{
// LibraryImport's source generator doesn't emit an implementation for pre-.NET 7 targets
// because the generated code relies on runtime APIs introduced in .NET 7.
#if NET7_0_OR_GREATER
[LibraryImport("libc", EntryPoint = "kill", SetLastError = true)]
public static partial int Kill(int pid, int sig);
#else
[DllImport("libc", EntryPoint = "kill", SetLastError = true)]
public static extern int Kill(int pid, int sig);
#endif
}
}
Loading