Skip to content

Remove explicit Microsoft.SourceLink.GitHub package reference#321

Merged
Tyrrrz merged 2 commits intomasterfrom
copilot/remove-source-link-package-reference
Mar 2, 2026
Merged

Remove explicit Microsoft.SourceLink.GitHub package reference#321
Tyrrrz merged 2 commits intomasterfrom
copilot/remove-source-link-package-reference

Conversation

Copy link
Contributor

Copilot AI commented Mar 2, 2026

Since .NET 8 SDK, Source Link support for GitHub-hosted repositories is built into the SDK — the Microsoft.SourceLink.GitHub NuGet package is redundant.

Changes

  • CliWrap/CliWrap.csproj — removed PackageReference for Microsoft.SourceLink.GitHub
  • Directory.Packages.props — removed corresponding PackageVersion entry
Original prompt

Background

Since .NET 8 SDK, Source Link support is built directly into the SDK for GitHub-hosted repositories. It is no longer necessary to explicitly reference the Microsoft.SourceLink.GitHub NuGet package.

Task

Remove all explicit references to Microsoft.SourceLink.GitHub from the project.

In CliWrap/CliWrap.csproj, remove the following line:

<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="all" />

If there is a corresponding PackageVersion entry for Microsoft.SourceLink.GitHub in Directory.Packages.props (if that file exists), remove that entry too.

Do not make any other changes. The built-in SDK Source Link support will take over automatically.

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…T 8+ SDK)

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
@Tyrrrz Tyrrrz marked this pull request as ready for review March 2, 2026 11:31
Copilot AI review requested due to automatic review settings March 2, 2026 11:31
Copilot AI changed the title [WIP] Remove explicit reference to Microsoft.SourceLink.GitHub Remove explicit Microsoft.SourceLink.GitHub package reference Mar 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes explicit Microsoft.SourceLink.GitHub dependency declarations so Source Link is provided by the .NET SDK instead of an explicit NuGet package reference.

Changes:

  • Removed the central PackageVersion entry for Microsoft.SourceLink.GitHub.
  • Removed the PackageReference to Microsoft.SourceLink.GitHub from CliWrap/CliWrap.csproj.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Directory.Packages.props Drops the centrally-managed version entry for Microsoft.SourceLink.GitHub.
CliWrap/CliWrap.csproj Removes the explicit SourceLink package reference from the library project.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.48%. Comparing base (69835ee) to head (3dd35da).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          45       45           
  Lines        1215     1215           
  Branches       89       89           
=======================================
  Hits         1148     1148           
  Misses         42       42           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants