-
-
Notifications
You must be signed in to change notification settings - Fork 278
Add tuple deconstruction and implicit conversions to [Buffered]CommandResult
#307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 94.75% 94.78% +0.03%
==========================================
Files 47 47
Lines 1202 1209 +7
Branches 94 94
==========================================
+ Hits 1139 1146 +7
Misses 38 38
Partials 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds convenience features to CommandResult and BufferedCommandResult classes, including tuple deconstruction and implicit conversion operators. These features simplify common usage patterns when working with command execution results.
- Added implicit conversion operators to extract exit code and success status from
CommandResult - Added deconstruction and implicit string conversion to
BufferedCommandResult - Updated documentation with examples showing the new usage patterns
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Readme.md | Added documentation for tuple deconstruction and implicit conversions; added reference to CliWrap.Immersive extension package; improved "Process information" section heading |
| CliWrap/CommandResult.cs | Added implicit conversion operators to int (exit code) and bool (success status) |
| CliWrap/Buffered/BufferedCommandResult.cs | Added Deconstruct method for tuple deconstruction and implicit conversion to string (standard output) |
| CliWrap/Buffered/BufferedCommandExtensions.cs | Updated XML documentation to use <inheritdoc> reference |
| CliWrap/EventStream/PushEventStreamCommandExtensions.cs | Updated XML documentation to use <inheritdoc> reference |
| CliWrap/EventStream/PullEventStreamCommandExtensions.cs | Updated XML documentation to use <inheritdoc> reference |
| CliWrap.Tests/ExecutionSpecs.cs | Added test for implicit conversions on CommandResult |
| CliWrap.Tests/BufferingSpecs.cs | Added tests for implicit conversion and deconstruction on BufferedCommandResult |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.