Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 19, 2025

No description provided.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.78%. Comparing base (c5cf2b9) to head (d30cf63).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   94.75%   94.78%   +0.03%     
==========================================
  Files          47       47              
  Lines        1202     1209       +7     
  Branches       94       94              
==========================================
+ Hits         1139     1146       +7     
  Misses         38       38              
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot finished reviewing on behalf of Tyrrrz November 19, 2025 18:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds convenience features to CommandResult and BufferedCommandResult classes, including tuple deconstruction and implicit conversion operators. These features simplify common usage patterns when working with command execution results.

  • Added implicit conversion operators to extract exit code and success status from CommandResult
  • Added deconstruction and implicit string conversion to BufferedCommandResult
  • Updated documentation with examples showing the new usage patterns

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Readme.md Added documentation for tuple deconstruction and implicit conversions; added reference to CliWrap.Immersive extension package; improved "Process information" section heading
CliWrap/CommandResult.cs Added implicit conversion operators to int (exit code) and bool (success status)
CliWrap/Buffered/BufferedCommandResult.cs Added Deconstruct method for tuple deconstruction and implicit conversion to string (standard output)
CliWrap/Buffered/BufferedCommandExtensions.cs Updated XML documentation to use <inheritdoc> reference
CliWrap/EventStream/PushEventStreamCommandExtensions.cs Updated XML documentation to use <inheritdoc> reference
CliWrap/EventStream/PullEventStreamCommandExtensions.cs Updated XML documentation to use <inheritdoc> reference
CliWrap.Tests/ExecutionSpecs.cs Added test for implicit conversions on CommandResult
CliWrap.Tests/BufferingSpecs.cs Added tests for implicit conversion and deconstruction on BufferedCommandResult

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 13bc13d into master Nov 19, 2025
7 checks passed
@Tyrrrz Tyrrrz deleted the magic branch November 19, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants