-
-
Notifications
You must be signed in to change notification settings - Fork 278
Drop official support for .NET Framework #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR drops official support for .NET Framework by removing related tests and updating package references.
- Removed .NET Framework-specific tests and references.
- Updated package reference conditions using the new shorthand.
- Adjusted the condition for the System.Management package reference to reflect the new support policy.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Directory.Build.props | Updated condition syntax for nullability annotations. |
| CliWrap/CliWrap.csproj | Upgraded package versions and revised MSBuild conditions. |
| CliWrap.Tests/CliWrap.Tests.csproj | Removed .NET Framework (net48) target from test suites. |
| CliWrap.Tests.Dummy/CliWrap.Tests.Dummy.csproj | Simplified target framework configuration by removing net48 support. |
Comments suppressed due to low confidence (1)
CliWrap/CliWrap.csproj:43
- Verify that the updated condition for including the System.Management package accurately reflects the intended framework targets without inadvertently excluding other desired frameworks.
Condition="!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'netcoreapp3.0'))"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 88.81% 94.69% +5.88%
==========================================
Files 48 48
Lines 1207 1207
Branches 95 95
==========================================
+ Hits 1072 1143 +71
+ Misses 109 38 -71
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Supporting .NET Framework in CliWrap has started taking up too much effort. Considering that .NET Framework is legacy technology at this point and .NET (Core) is pretty much as mature as it gets (having been out for 9+ years), I see no reason to justify the effort to maintain official support for .NET Framework in this library.
Users can still continue to use CliWrap with .NET Framework, however they will need to figure out any run-time compatibility issues themselves. CliWrap will continue targeting .NET Standard 2.0 which should ensure compatibility with .NET Framework on paper (and, as experience shows, only on paper).
This PR removes tests running against .NET Fx and updates package references that previously caused compatibility issues. It also removes a framework reference on
System.Management.