-
-
Notifications
You must be signed in to change notification settings - Fork 278
Add Command.ExecuteAsync(...) overload that allows direct manipulation of ProcessStartInfo/Process
#290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ion of `ProcessStartInfo`/`Process`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new overload for Command.ExecuteAsync that enables direct configuration of the underlying ProcessStartInfo and Process, catering to edge cases where the CliWrap abstraction needs to be bypassed.
- Introduces a new overload accepting configuration actions for ProcessStartInfo and Process.
- Retains the previous overload by internally calling the new one with null configuration actions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
==========================================
+ Coverage 95.01% 95.03% +0.02%
==========================================
Files 48 48
Lines 1203 1208 +5
Branches 89 95 +6
==========================================
+ Hits 1143 1148 +5
Misses 37 37
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ion of `ProcessStartInfo`/`Process` (Tyrrrz#290)
Closes #79
Example usage:
Note that using this overload is reserved for very rare edge cases where you need to break out of CliWrap's abstraction model (such as #79) and configure the low-level process properties/behavior manually. Do not rely on it in the general case.
If something breaks when using this overload, you're on your own.