Use Encoding.Default instead of Console.OutputEncoding as the default encoding
#262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault encoding Closes #261
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 94.98% 95.00% +0.01%
==========================================
Files 46 46
Lines 1097 1100 +3
Branches 85 85
==========================================
+ Hits 1042 1045 +3
Misses 35 35
Partials 20 20 ☔ View full report in Codecov by Sentry. |
heqianwang
pushed a commit
to workleap/wl-leap-local-dev
that referenced
this pull request
Mar 20, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [CliWrap](https://github.com/Tyrrrz/CliWrap) | nuget | patch | `3.6.6` -> `3.6.7` | --- ### Release Notes <details> <summary>Tyrrrz/CliWrap (CliWrap)</summary> ### [`v3.6.7`](https://github.com/Tyrrrz/CliWrap/releases/tag/3.6.7) [Compare Source](Tyrrrz/CliWrap@3.6.6...3.6.7) #### What's Changed - Bump the nuget group with 6 updates by [@​dependabot](https://github.com/dependabot) in Tyrrrz/CliWrap#245 - Bump the nuget group with 2 updates by [@​dependabot](https://github.com/dependabot) in Tyrrrz/CliWrap#252 - Bump the nuget group with 3 updates by [@​dependabot](https://github.com/dependabot) in Tyrrrz/CliWrap#255 - Proper cleanup for deployed process signaler by [@​xpherism](https://github.com/xpherism) in Tyrrrz/CliWrap#259 - Bump the nuget group with 4 updates by [@​dependabot](https://github.com/dependabot) in Tyrrrz/CliWrap#260 - Use `Encoding.Default` instead of `Console.OutputEncoding` as the default encoding by [@​Tyrrrz](https://github.com/Tyrrrz) in Tyrrrz/CliWrap#262 #### New Contributors - [@​dependabot](https://github.com/dependabot) made their first contribution in Tyrrrz/CliWrap#245 - [@​xpherism](https://github.com/xpherism) made their first contribution in Tyrrrz/CliWrap#259 **Full Changelog**: Tyrrrz/CliWrap@3.6.6...3.6.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or PR is renamed to start with "rebase!". 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #261
.NET uses
Encoding.DefaultinProcess: #261 (comment)