Align recorder transcription with file transcription - #1121
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 4 reviews per rolling hour; 1 remains after this review. 📝 WalkthroughWalkthroughFinal transcription and retranscription now share a helper that uses the file transcription pipeline. Tests update the mock plugin and verify pipeline selection for calendar meetings and recorder retranscription. ChangesFinal transcription pipeline
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR aligns Recorder finalization and retries with the established file-transcription path and adds targeted regression coverage; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Issue context
Issue #1091 reports that automatic Microsoft Teams meeting recordings produce incomplete transcripts even though transcribing the saved recording through File Transcription is substantially more complete. The reporter confirmed the problem still occurs in the August 17 daily build, which already contains the earlier finalized-audio fix from #1109.
The remaining difference was the transcription entry point: Recorder finalization used the basic batch overload, while File Transcription used the source-progress-aware overload. Engines such as WhisperKit implement those as distinct paths. This change gives Recorder finalization and Recorder retries the same pipeline selection as File Transcription while preserving the existing live-session result path.
Closes #1091
User impact
Automatic meeting transcripts and Recorder retries now use the same long-audio transcription path as manual File Transcription when a finalized batch transcription is required.
Test plan
Summary by CodeRabbit
Bug Fixes
Tests