Fixed the intrinsic type name identifier typo from "instrinct" to "intrinsic"#484
Merged
blakeembrey merged 5 commits intoTypeStrong:masterfrom Apr 25, 2017
Merged
Conversation
Fixed the intrinsic type name identifier which was "instrinct" before. Incremented to version 0.6.0.
Member
|
Please don't change the version number. I can merge any fixes when you undo it. |
Contributor
Author
|
Sorry about that. I was unsure about your comment in #482 |
Member
|
No problem. You generally avoid bumping versions, especially as part of a feature, because people normally have an existing release process and tagging to do. I just meant I would bump the minor version when we release this 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the type name identifier of the "intrinsic" type which was "instrinct" before.
Changed the type model, test specs were updated automatically.
As this is a breaking change, the minor version was incremented.
So as of 0.6.0 if you rely on the output of typedoc using the --json option, please check your code for the occurrence of "instrinct"!
closes #146