-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@example tag titles cannot be derived from CommentTag type #2440
Comments
This seems like a reasonable way to handle things 👍 JSDoc |
Hmm... and what happens if there's a VSCode doesn't support this idea as a thing, just rendering it on the next line after the block. Since TS doesn't even parse If you toss an |
This seems reasonable to me. I guess any more might need a change to the tsdoc specs? |
…#26343) # Why Update TypeDoc to the latest release to keep up to day and officially support package source build with TS 5.2+. All data files have been changed, since TypeDoc removed on of legacy the entry Kind enum values (`ObjectLiteral`) which caused a shift of existing values after it. # How Update TypeDoc to the latest version, rewrite TypeDoc Application calls execution, update Docs snapshot and unit tests to match the data. Unfortunately, the data generation command outputs not valid for our use case warning due to TypeStrong/typedoc#2440, but it doesn't matter in our case due to using the JSON data only, and custom renderers, which can handle both comment structures correctly, so those warning can be ignored. We can alter source comments in the future, when stable SDK 50 will be releases to avoid shipping large amount of changes in preview/RC stage. > [!important] > No backport of `expo-assets` data for SDK 50 has been made due to #26310, which probably did not become part od SDK 50, but if will land, we will need to backport the package data, since the structure and exported fields have changed. # Test Plan The changes have been reviewed locally. Reference doc pages contains a full, and expected data. All lint checks and tests are passing.
…expo#26343) # Why Update TypeDoc to the latest release to keep up to day and officially support package source build with TS 5.2+. All data files have been changed, since TypeDoc removed on of legacy the entry Kind enum values (`ObjectLiteral`) which caused a shift of existing values after it. # How Update TypeDoc to the latest version, rewrite TypeDoc Application calls execution, update Docs snapshot and unit tests to match the data. Unfortunately, the data generation command outputs not valid for our use case warning due to TypeStrong/typedoc#2440, but it doesn't matter in our case due to using the JSON data only, and custom renderers, which can handle both comment structures correctly, so those warning can be ignored. We can alter source comments in the future, when stable SDK 50 will be releases to avoid shipping large amount of changes in preview/RC stage. > [!important] > No backport of `expo-assets` data for SDK 50 has been made due to expo#26310, which probably did not become part od SDK 50, but if will land, we will need to backport the package data, since the structure and exported fields have changed. # Test Plan The changes have been reviewed locally. Reference doc pages contains a full, and expected data. All lint checks and tests are passing.
Fix minor breakages from last 7 months. Add handling for this typedoc change: TypeStrong/typedoc#2440
Fix minor breakages from last 7 months. Add handling for this typedoc change: TypeStrong/typedoc#2440
Search terms
Actual Behavior
The tsdoc website says:
The example is parsed as a CommentTag which has
content
andtag
fields and an optionalname
field.Any text on the same line as the
@example
tag appears in thecontent
list along with any other text.E.g.
Becomes:
So it's impossible to tell if there was a title for the example.
Expected Behavior
The CommentTag.name field docs say:
So if present, the example title should probably be in the
name
field?Environment
The text was updated successfully, but these errors were encountered: