feat: command history #757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try upgrading to the latest Node 11 if you experience any issues. Closes TypeStrong#259
blakeembrey
reviewed
Jan 21, 2019
| repl.history = fs.readFileSync(file, 'utf8').split(os.EOL) | ||
| } | ||
| repl.on('exit', () => { | ||
| fs.writeFileSync(file, repl.history.join(os.EOL)) |
There was a problem hiding this comment.
How does this work with two processes running? It seems like one would just overwrite the other's history?
There was a problem hiding this comment.
Yeah, that's how the node repl works. We could re-read the file in the exit listener and prepend/dedupe the repl.history, but I'd prefer someone else add that in another PR.
Merged
blakeembrey
reviewed
Jan 21, 2019
|
|
||
| // TODO: Use `repl: REPLServer` when history-related properties are added to @types/node | ||
| export function useHistory (repl: any) { | ||
| repl.historySize = process.env.TS_NODE_HISTORY !== '' |
There was a problem hiding this comment.
We have a place for configuration loaded from environment variables, we should re-use that.
There was a problem hiding this comment.
Maintainer edits are enabled, if you want to help out.
|
Opted for the native implementation using https://nodejs.org/api/repl.html#repl_replserver_setuphistory_historypath_callback in 35d8a0c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try upgrading to the latest Node 11 if you experience any issues. Looks like they had to revert a buggy feature in 11.4.0 (nodejs/node#24804).
Nothing crazy going on here. Just basic history support! 😄
~/.ts_node_history$TS_NODE_HISTORYcan be used to customize the file path$TS_NODE_HISTORY_SIZEcan be used to limit the number of saved lines$TS_NODE_HISTORYis an empty string, history is disabled$TS_NODE_HISTORY_SIZEis zero, history is disabledCloses #259