Disable detaching sub-process on Windows #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
@blakeembrey this should solve the reported issue. |
|
I found ts-node with no arguments was exiting without giving me a repl on Windows and traced it down to the detached spawn not working as expected with stdio inherited. The source branch of this PR had the fix which came to mind (i.e. backs out for Windows to the behaviour before #419 came along), and so I switched to it and solved my problem, so looks good to me. |
|
This fixed the issue for me 👍 |
stelcheck
added a commit
to stelcheck/ts-node
that referenced
this pull request
Dec 20, 2017
This commit: 1. Cleans up how the code is loaded 2. Removes the necessity to use 'spawn' Replaces TypeStrong#476 Replaces TypeStrong#489
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480